Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about breaking java time changes #38720

Merged
merged 6 commits into from
Feb 14, 2019

Conversation

spinscale
Copy link
Contributor

This adds documentation for changes regarding the joda/java time switch.

@spinscale spinscale added >docs General docs changes :Core/Infra/Core Core issues without another label v7.0.0 labels Feb 11, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it makes sense to document those changes in a separate file. I left a few suggestions.

docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved
@spinscale
Copy link
Contributor Author

took care of all your comments. I also grepped through the whole documentation and removed any mentions of joda time or joda specific formats in another commit within this PR

Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating, this looks great. I left only very minor comments (which won't require another review round). LGTM

docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved
docs/reference/migration/migrate_7_0/java_time.asciidoc Outdated Show resolved Hide resolved
@spinscale spinscale merged commit 309a5d8 into elastic:7.0 Feb 14, 2019
spinscale added a commit to spinscale/elasticsearch that referenced this pull request Feb 14, 2019
In addition remove joda time mentions across the docs, make
sure links are updated to java time javadocs.
spinscale added a commit to spinscale/elasticsearch that referenced this pull request Feb 14, 2019
In addition remove joda time mentions across the docs, make 
sure links are updated to java time javadocs.
spinscale added a commit that referenced this pull request Feb 14, 2019
In addition remove joda time mentions across the docs, make 
sure links are updated to java time javadocs.

Forward port of #38720
spinscale added a commit that referenced this pull request Feb 14, 2019
This is the forward port of #38720 (not containing the 7.0 migration docs)
@rjernst
Copy link
Member

rjernst commented Feb 14, 2019

@spinscale This should probably be partially backported to 6.7?

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Feb 14, 2019
* elastic/master:
  Remove immediate operation retry after mapping update (elastic#38873)
  Remove mentioning of types from bulk API docs (elastic#38896)
  SQL: change JDBC setup URL in the documentation (elastic#38564)
  Skip BWC tests in checkPart1 and checkPart2 (elastic#38730)
  Enable silent FollowersCheckerTest (elastic#38851)
  Update TESTING.asciidoc with platform specific instructions (elastic#38802)
  Use consistent view of realms for authentication (elastic#38815)
  Stabilize RareClusterState (elastic#38671)
  Increase Timeout in UnicastZenPingTests (elastic#38893)
  Do not recommend installing vagrant-winrm elastic#38887
  _cat/indices with Security, hide names when wildcard (elastic#38824)
  SQL: fall back to using the field name for column label (elastic#38842)
  Fix LocalIndexFollowingIT#testRemoveRemoteConnection() test (elastic#38709)
  Remove joda time mentions in documentation (elastic#38720)
  Add enabled status for token and api key service (elastic#38687)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Core Core issues without another label >docs General docs changes v7.0.0-rc1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants