Make pullFixture a task dependency of resolveAllDependencies #38956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this change we will pull the docker test fixtures ( and thus cache the images ) for older versions too as the `resolveAllDependencies` is already being called on the bwc checkouts too.
alpar-t
added
>non-issue
:Delivery/Build
|
Pinging @elastic/es-core-infra |
dliappis
approved these changes
Feb 18, 2019
.ci/packer_cache.sh
Outdated
| @@ -21,4 +21,4 @@ export JAVA_HOME="${HOME}"/.java/${ES_BUILD_JAVA} | |||
| export JAVA8_HOME="${HOME}"/.java/java8 | |||
| export JAVA11_HOME="${HOME}"/.java/java11 | |||
| export JAVA12_HOME="${HOME}"/.java/java12 | |||
| ./gradlew --parallel clean pullFixture --scan -Porg.elasticsearch.acceptScanTOS=true -s resolveAllDependencies | |||
| ./gradlew --parallel clean --scan -Porg.elasticsearch.acceptScanTOS=true -s resolveAllDependencies | |||
There was a problem hiding this comment.
Nit: we can convert double spaces before clean and --scan to single spaces?
alpar-t
added a commit
that referenced
this pull request
Feb 18, 2019
* Make pullFixture a task dependency of resolveAllDependencies With this change we will pull the docker test fixtures ( and thus cache the images ) for older versions too as the `resolveAllDependencies` is already being called on the bwc checkouts too.
alpar-t
added a commit
that referenced
this pull request
Feb 18, 2019
* Make pullFixture a task dependency of resolveAllDependencies With this change we will pull the docker test fixtures ( and thus cache the images ) for older versions too as the `resolveAllDependencies` is already being called on the bwc checkouts too.
alpar-t
added a commit
that referenced
this pull request
Feb 18, 2019
* Make pullFixture a task dependency of resolveAllDependencies With this change we will pull the docker test fixtures ( and thus cache the images ) for older versions too as the `resolveAllDependencies` is already being called on the bwc checkouts too.
alpar-t
added a commit
that referenced
this pull request
Feb 18, 2019
* Make pullFixture a task dependency of resolveAllDependencies With this change we will pull the docker test fixtures ( and thus cache the images ) for older versions too as the `resolveAllDependencies` is already being called on the bwc checkouts too.
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Feb 18, 2019
…ate-file * elastic/master: Remove tests and branches that will never execute (elastic#38772) also check ccr stats api return empty response in ensureNoCcrTasks() Add overlapping, before, after filters to intervals query (elastic#38999) Mute test elastic#38949 Add remote recovery to ShardFollowTaskReplicationTests (elastic#39007) [ML] More advanced post-test cleanup of ML indices (elastic#39049) wait for shard to be allocated before executing a resume follow api Update track-total-hits.asciidoc Force kill testcluster nodes (elastic#37353) Make pullFixture a task dependency of resolveAllDependencies (elastic#38956) set minimum supported version (elastic#39043) Enforce Completion Context Limit (elastic#38675) Mute test Don't close caches while there might still be in-flight requests. (elastic#38958) Fix elastic#38623 remove xpack namespace REST API (elastic#38625) Add data frame feature (elastic#38934) Test bi-directional index following during a rolling upgrade. (elastic#38962) Generate mvn pom for ssl-config library (elastic#39019) Mute testRetentionLeaseIsRenewedDuringRecovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we will pull the docker test fixtures ( and thus cache
the images ) for older versions too as the
resolveAllDependenciesisalready being called on the bwc checkouts too.
Closes #38832