Use TestFixturesPlugin to Run Minio in Tests (#37852) #38973
Conversation
talevy
added
>test
|
Pinging @elastic/es-distributed |
* Use TestFixturesPlugin to Run Minio in Tests * Closes elastic#37680 * Closes elastic#37783
talevy
force-pushed
the
backport-37852
branch
from
bf9219d
to
6fb6847
Compare
|
run elasticsearch-ci/1 |
1 similar comment
|
run elasticsearch-ci/1 |
|
run elasticsearch-ci/1 |
|
doesn't look like this backported cleanly. can check next week |
* Disable Minio fixture and tests that require it when fixtures are disabled or Docker is not available * Relates elastic#37852
|
oh, ok. I've merge that into here so we find out. thank you @original-brownbear! |
|
run elasticsearch-ci/1 |
|
@original-brownbear I might need help here... 😄 I included the PR you mentioned, and it fails in the same way |
|
@talevy sure, will take a look tomorrow :) |
| description = "Runs REST tests using the Minio repository." | ||
| } | ||
|
|
||
| preProcessFixture.dependsOn(writeDockerFile) |
There was a problem hiding this comment.
@atorok you may be able to help here better than me :) Is there anything different about this task in 6.6 maybe that would prevent this way of triggering the docker file write from working? It seems this task isn't executed before composeUp and thus composeUp fails.
There was a problem hiding this comment.
I don't usually back port build changes this far so I'm fairly sure there's some change to the plugin missing in this branch.
There was a problem hiding this comment.
Ah yea that makes sense, I guess we could just make composeUp depend on writeDockerFile as a workaround in 6.6?
There was a problem hiding this comment.
There was a problem hiding this comment.
@talevy ah sorry missed your ping. Yea but I remember there was some weirdness around this actually happening before fixes by Alpar => let's try triggering on composeUp :)
|
thank you for the help Armin. to be honest, I haven't been keeping up with build |
|
thanks Armin! I'll run the tests again just to add more confidence |
|
run elasticsearch-ci/1 |
Use TestFixturesPlugin to Run Minio in Tests
Closes [CI] minio fails due to port clashes #37680
Closes Use TestFixturesPlugin to Spin up Minio in S3 Plugin Tests #37783
backport of #37852