Fixed required fields and paths list #39358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-security |
|
@elasticmachine run elasticsearch-ci/packaging-sample |
bizybot
pushed a commit
to bizybot/elasticsearch
that referenced
this pull request
Feb 27, 2019
Some small fix for the `x-pack` rest api spec. * In both `security.enable_user.json` and `security.disable_user.json` the `username` parameter was `false` instead of `true` (the documentation is already correct). * In `security.get_privileges.json` there were missing all the possible paths since the path parameters are not required. This fix aligns the document with the rest of the spec, where all the possible combinations are listed.
bizybot
pushed a commit
to bizybot/elasticsearch
that referenced
this pull request
Feb 27, 2019
Some small fix for the `x-pack` rest api spec. * In both `security.enable_user.json` and `security.disable_user.json` the `username` parameter was `false` instead of `true` (the documentation is already correct). * In `security.get_privileges.json` there were missing all the possible paths since the path parameters are not required. This fix aligns the document with the rest of the spec, where all the possible combinations are listed.
bizybot
pushed a commit
to bizybot/elasticsearch
that referenced
this pull request
Feb 27, 2019
Some small fix for the `x-pack` rest api spec. * In both `security.enable_user.json` and `security.disable_user.json` the `username` parameter was `false` instead of `true` (the documentation is already correct). * In `security.get_privileges.json` there were missing all the possible paths since the path parameters are not required. This fix aligns the document with the rest of the spec, where all the possible combinations are listed.
bizybot
added a commit
that referenced
this pull request
Feb 27, 2019
Some small fix for the `x-pack` rest api spec. * In both `security.enable_user.json` and `security.disable_user.json` the `username` parameter was `false` instead of `true` (the documentation is already correct). * In `security.get_privileges.json` there were missing all the possible paths since the path parameters are not required. This fix aligns the document with the rest of the spec, where all the possible combinations are listed.
bizybot
added a commit
that referenced
this pull request
Feb 27, 2019
Some small fix for the `x-pack` rest api spec. * In both `security.enable_user.json` and `security.disable_user.json` the `username` parameter was `false` instead of `true` (the documentation is already correct). * In `security.get_privileges.json` there were missing all the possible paths since the path parameters are not required. This fix aligns the document with the rest of the spec, where all the possible combinations are listed.
bizybot
added a commit
that referenced
this pull request
Feb 27, 2019
Some small fix for the `x-pack` rest api spec. * In both `security.enable_user.json` and `security.disable_user.json` the `username` parameter was `false` instead of `true` (the documentation is already correct). * In `security.get_privileges.json` there were missing all the possible paths since the path parameters are not required. This fix aligns the document with the rest of the spec, where all the possible combinations are listed.
|
@jaymode sorry for the delay, it was evening for me. Next time! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Some small fix for the
x-packrest api spec.security.enable_user.jsonandsecurity.disable_user.jsontheusernameparameter wasfalseinstead oftrue(the documentation is already correct).security.get_privileges.jsonthere were missing all the possible paths since the path parameters are not required. This fix aligns the document with the rest of the spec, where all the possible combinations are listed.cc @elastic/es-clients