Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: Enhance checks for inexact fields #39427

Merged
merged 4 commits into from
Feb 28, 2019
Merged

SQL: Enhance checks for inexact fields #39427

merged 4 commits into from
Feb 28, 2019

Commits on Feb 27, 2019

  1. SQL: Enhance checks for inexact fields 

    For functions: move checks for `text` fields without underlying `keyword`
fields or with many of them (ambiguity) to the type resolution stage.

For Order By/Group By: move checks to the `Verifier` to catch early
before `QueryTranslator` or execution.

Fixes: elastic#38501
    @matriv
    matriv committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    4456106 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'upstream/master' into mt/fix-38501

    @matriv
    matriv committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    12d705a View commit details
    Browse the repository at this point in the history

  3. Address comments

    @matriv
    matriv committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    0ea7c4c View commit details
    Browse the repository at this point in the history

  4. Addressed comments

    @matriv
    matriv committed Feb 27, 2019
    Configuration menu
    Copy the full SHA
    cda66ca View commit details
    Browse the repository at this point in the history