Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation on remote recovery #39483

Merged
merged 9 commits into from
Mar 5, 2019

Conversation

Tim-Brooks
Copy link
Contributor

This is related to #35975. It adds documentation on the remote recovery
process. Additionally, it adds documentation about the various settings
that can impact the process.

@Tim-Brooks Tim-Brooks added >docs General docs changes v7.0.0 :Distributed/CCR Issues around the Cross Cluster State Replication features v6.7.0 v8.0.0 v7.2.0 labels Feb 27, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tbrooks8. I've left mainly minor comments, this is looking very good already.

docs/reference/ccr/remote-recovery.asciidoc Outdated Show resolved Hide resolved
docs/reference/ccr/remote-recovery.asciidoc Outdated Show resolved Hide resolved
docs/reference/ccr/remote-recovery.asciidoc Outdated Show resolved Hide resolved
docs/reference/ccr/remote-recovery.asciidoc Outdated Show resolved Hide resolved
@lcawl
Copy link
Contributor

lcawl commented Mar 1, 2019

@tbrooks8 Were you intending this new page to be added to the existing CCR documentation in the Stack Overview? If so, I added a commit that puts it here:
image
If that's not what you intended, let me know.

Information about an in-progress remote recovery can be obtained using the
{ref}/cat-recovery.html[recovery API] on the follower cluster. Remote recoveries are implemented
using the {ref}/modules-snapshots.html[snapshot and restore] infrastructure. This means that
on-going remote recoveries will be labelled as type `snapshot` in the recovery api.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
on-going remote recoveries will be labelled as type `snapshot` in the recovery api.
on-going remote recoveries are labelled as type `snapshot` in the recovery API.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some way to know when the recovery process is complete (other than using the recovery API)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recovery API is the primary. You could probably use the cat indices api to check if the index is green. You can also add a parameter to a follower request to wait until the process is completed. However, that is documented on the put follow request page.

using the {ref}/modules-snapshots.html[snapshot and restore] infrastructure. This means that
on-going remote recoveries will be labelled as type `snapshot` in the recovery api.

The following setting can be used to rate-limit the data transmitted during remote
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally store these types of settings in the Elasticsearch Reference in pages like the ones linked here: https://www.elastic.co/guide/en/elasticsearch/reference/master/settings-xpack.html

I am happy to create that page if you agree.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that makes sense.

Copy link
Contributor

@lcawl lcawl Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've added those changes.

@Tim-Brooks
Copy link
Contributor Author

Were you intending this new page to be added to the existing CCR documentation in the Stack Overview?

Yes. Thanks.

@Tim-Brooks Tim-Brooks requested a review from lcawl March 4, 2019 21:39
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Tim-Brooks Tim-Brooks merged commit ee41b22 into elastic:master Mar 5, 2019
Tim-Brooks added a commit that referenced this pull request Mar 5, 2019
This is related to #35975. It adds documentation on the remote recovery
process. Additionally, it adds documentation about the various settings
that can impact the process.
Tim-Brooks added a commit that referenced this pull request Mar 5, 2019
This is related to #35975. It adds documentation on the remote recovery
process. Additionally, it adds documentation about the various settings
that can impact the process.
Tim-Brooks added a commit that referenced this pull request Mar 5, 2019
This is related to #35975. It adds documentation on the remote recovery
process. Additionally, it adds documentation about the various settings
that can impact the process.
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Mar 6, 2019
* 6.7: (39 commits)
  Remove beta label from CCR (elastic#39722)
  Rename retention lease setting (elastic#39719)
  Add Docker build type (elastic#39378)
  Use any index specified by .watches for Watcher (elastic#39541) (elastic#39706)
  Add documentation on remote recovery (elastic#39483)
  fix typo in synonym graph filter docs
  Removed incorrect ML YAML tests (elastic#39400)
  Improved Terms Aggregation documentation (elastic#38892)
  Fix Fuzziness#asDistance(String) (elastic#39643)
  Revert "unmute EvilLoggerTests#testDeprecatedSettings (elastic#38743)"
  Mute TokenAuthIntegTests.testExpiredTokensDeletedAfterExpiration (elastic#39690)
  Fix security index auto-create and state recovery race (elastic#39582)
  [DOCS] Sorts security APIs
  Check for .watches that wasn't upgraded properly (elastic#39609)
  Assert recovery done in testDoNotWaitForPendingSeqNo (elastic#39595)
  [DOCS] Updates API in Watcher transform context (elastic#39540)
  Fixing the custom object serialization bug in diffable utils. (elastic#39544)
  mute test
  SQL: Don't allow inexact fields for MIN/MAX (elastic#39563)
  Update release notes for 6.7.0
  ...
@Tim-Brooks Tim-Brooks deleted the remote_recovery_doc branch December 18, 2019 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/CCR Issues around the Cross Cluster State Replication features >docs General docs changes v6.7.0 v7.0.0-rc2 v7.2.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants