Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Switch to typeless APIs in ML native multi-node tests #39574

Merged

Conversation

droberts195
Copy link
Contributor

@droberts195 droberts195 commented Mar 1, 2019

Following #39256 some of these tests were generating
errors when indexing documents. For consistency it's
best that all of them use typeless APIs.

Fixes #39575

Following elastic#39256 some of these tests were generating
errors when indexing documents.  For consistency it's
best that all of them use typeless APIs.
@droberts195 droberts195 added >test Issues or PRs that are addressing/adding tests :ml Machine learning v8.0.0 labels Mar 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@droberts195
Copy link
Contributor Author

The error logging from type conflicts was contributing to #37339 (comment)

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195 droberts195 merged commit 11b58eb into elastic:master Mar 1, 2019
@droberts195 droberts195 deleted the ml-native-multi-node-tests-typeless branch March 1, 2019 19:27
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Mar 4, 2019
…9574)

Following elastic#39256 some of these tests were generating
errors when indexing documents.  For consistency it's
best that all of them use typeless APIs.
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Mar 4, 2019
…9574)

Following elastic#39256 some of these tests were generating
errors when indexing documents.  For consistency it's
best that all of them use typeless APIs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:ml Machine learning >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DeleteExpiredDataIT.testDeleteExpiredData failure
4 participants