Remove the index type from internal watcher indexes #39761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the "doc" type from watcher internal indexes. The template still carries the "_doc" type since that is needed for the internal representation. This impacts the .watches, .triggered-watches, and .watch-history indexes. External consumers do not need any changes since all external calls go through the _watcher API, and should not interact with the the .index directly. Relates elastic#38637
This was referenced Mar 6, 2019
|
Pinging @elastic/es-core-features |
jakelandis
commented
Mar 6, 2019
| @@ -29,7 +29,7 @@ | |||
|
|
|||
| public static final String TYPE = "index"; | |||
|
|
|||
| @Nullable final String docType; | |||
There was a problem hiding this comment.
The changes to this file (IndexAction) were missed in #37594. I added it here to help us find what to remove when we completely get rid of types. Apologizes for conflating the two issues.
jpountz
approved these changes
Mar 7, 2019
| @@ -69,7 +69,7 @@ public void testWatchNotFound() { | |||
| String watchId = "my_watch_id"; | |||
| doAnswer(invocation -> { | |||
| ActionListener<GetResponse> listener = (ActionListener<GetResponse>) invocation.getArguments()[1]; | |||
| listener.onResponse(new GetResponse(new GetResult(Watch.INDEX, Watch.DOC_TYPE, watchId, UNASSIGNED_SEQ_NO, 0, -1, false, | |||
| listener.onResponse(new GetResponse(new GetResult(Watch.INDEX, null, watchId, UNASSIGNED_SEQ_NO, 0, -1, false, | |||
There was a problem hiding this comment.
the response would have _doc as a type in practice
There was a problem hiding this comment.
++ to changing that to use default mapping instead
hub-cap
approved these changes
Mar 7, 2019
| @@ -69,7 +69,7 @@ public void testWatchNotFound() { | |||
| String watchId = "my_watch_id"; | |||
| doAnswer(invocation -> { | |||
| ActionListener<GetResponse> listener = (ActionListener<GetResponse>) invocation.getArguments()[1]; | |||
| listener.onResponse(new GetResponse(new GetResult(Watch.INDEX, Watch.DOC_TYPE, watchId, UNASSIGNED_SEQ_NO, 0, -1, false, | |||
| listener.onResponse(new GetResponse(new GetResult(Watch.INDEX, null, watchId, UNASSIGNED_SEQ_NO, 0, -1, false, | |||
There was a problem hiding this comment.
++ to changing that to use default mapping instead
|
@elasticmachine run elasticsearch-ci/1 |
1 similar comment
|
@elasticmachine run elasticsearch-ci/1 |
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Mar 8, 2019
This commit removes the "doc" type from watcher internal indexes. The template still carries the "_doc" type since that is needed for the internal representation. This impacts the .watches, .triggered-watches, and .watch-history indexes. External consumers do not need any changes since all external calls go through the _watcher API, and should not interact with the the .index directly. Relates elastic#38637
jakelandis
added a commit
to jakelandis/elasticsearch
that referenced
this pull request
Mar 8, 2019
This commit removes the "doc" type from watcher internal indexes. The template still carries the "_doc" type since that is needed for the internal representation. This impacts the .watches, .triggered-watches, and .watch-history indexes. External consumers do not need any changes since all external calls go through the _watcher API, and should not interact with the the .index directly. Relates elastic#38637
jakelandis
added a commit
that referenced
this pull request
Mar 8, 2019
This commit removes the "doc" type from watcher internal indexes. The template still carries the "_doc" type since that is needed for the internal representation. This impacts the .watches, .triggered-watches, and .watch-history indexes. External consumers do not need any changes since all external calls go through the _watcher API, and should not interact with the the .index directly. Relates #38637
jakelandis
added a commit
that referenced
this pull request
Mar 8, 2019
This commit removes the "doc" type from watcher internal indexes. The template still carries the "_doc" type since that is needed for the internal representation. This impacts the .watches, .triggered-watches, and .watch-history indexes. External consumers do not need any changes since all external calls go through the _watcher API, and should not interact with the the .index directly. Relates #38637
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes the "doc" type from watcher internal indexes.
The template still carries the "_doc" type since that is needed for
the internal representation.
This impacts the .watches, .triggered-watches, and .watch-history indexes.
External consumers do not need any changes since all external calls
go through the _watcher API, and should not interact with the the .index directly.
Relates #38637