Enforce retention leases require soft deletes #39922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>bug
v7.0.0
:Distributed/Distributed
|
Pinging @elastic/es-distributed |
jasontedor
reviewed
Mar 11, 2019
|
@jasontedor Thanks for looking. I pushed changes. Can you have another look please? |
|
@jasontedor thanks! |
dnhatn
added a commit
that referenced
this pull request
Mar 12, 2019
If a primary on 6.7 and a replica on 5.6 are running more than 5 minutes (retention leases background sync interval), the retention leases background sync will be triggered, and it will trip 6.7 node due to the illegal checkpoint value. We can fix the problem by making the returned checkpoint depends on the node version. This PR, however, chooses to enforce retention leases require soft deletes, and make retention leases sync noop if soft deletes is disabled instead. Closes #39914
dnhatn
added a commit
that referenced
this pull request
Mar 12, 2019
|
Thanks @dnhatn. Great change. |
dnhatn
added a commit
that referenced
this pull request
Mar 12, 2019
dnhatn
added a commit
that referenced
this pull request
Mar 12, 2019
If a primary on 6.7 and a replica on 5.6 are running more than 5 minutes (retention leases background sync interval), the retention leases background sync will be triggered, and it will trip 6.7 node due to the illegal checkpoint value. We can fix the problem by making the returned checkpoint depends on the node version. This PR, however, chooses to enforce retention leases require soft deletes, and make retention leases sync noop if soft deletes is disabled instead. Closes #39914
dnhatn
added a commit
that referenced
this pull request
Mar 12, 2019
dnhatn
added a commit
that referenced
this pull request
Mar 12, 2019
If a primary on 6.7 and a replica on 5.6 are running more than 5 minutes (retention leases background sync interval), the retention leases background sync will be triggered, and it will trip 6.7 node due to the illegal checkpoint value. We can fix the problem by making the returned checkpoint depends on the node version. This PR, however, chooses to enforce retention leases require soft deletes, and make retention leases sync noop if soft deletes is disabled instead. Closes #39914
polyfractal
pushed a commit
to polyfractal/elasticsearch
that referenced
this pull request
Mar 19, 2019
If a primary on 6.7 and a replica on 5.6 are running more than 5 minutes (retention leases background sync interval), the retention leases background sync will be triggered, and it will trip 6.7 node due to the illegal checkpoint value. We can fix the problem by making the returned checkpoint depends on the node version. This PR, however, chooses to enforce retention leases require soft deletes, and make retention leases sync noop if soft deletes is disabled instead. Closes elastic#39914
polyfractal
pushed a commit
to polyfractal/elasticsearch
that referenced
this pull request
Mar 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a primary on 6.7 and a replica on 5.6 are running more than 5 minutes (retention leases background sync interval), the retention leases background sync will be triggered, and it will trip 6.7 node due to the illegal checkpoint value. We can fix the problem by making the returned checkpoint depend on the node version. This PR, however, chooses to enforce retention leases require soft deletes, and make retention-leases sync noop if soft deletes is disabled instead.
Closes #39914
I tried but failed to come up with a useful test. Any suggestions are welcome!