Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOCS] First pass at upgrade updates for 7.0. #39944

Merged
merged 5 commits into from
Mar 13, 2019
Merged

[DOCS] First pass at upgrade updates for 7.0. #39944

merged 5 commits into from
Mar 13, 2019

Conversation

debadair
Copy link
Contributor

No description provided.

@debadair debadair added >docs General docs changes :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v7.0.0 labels Mar 12, 2019
@debadair debadair requested a review from lcawl March 12, 2019 02:24
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

lcawl
lcawl reviewed Mar 12, 2019
View reviewed changes
docs/reference/upgrade/close-ml.asciidoc
@@ -1,32 +1,33 @@
[testenv="platinum"]

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the changes in this page are correct (i.e. you'd need to have the third bullet applied to the first paragraph too at the very least). If the bullet form is desired, can we please separate this page's changes into a new PR and I can pursue them with the appropriate reviewers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't split this out yet, but I will.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created #40006

@lcawl lcawl mentioned this pull request Mar 13, 2019
Merged
lcawl
lcawl approved these changes Mar 13, 2019
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one more comment but otherwise LGTM

@debadair debadair merged commit 4834b93 into elastic:7.0 Mar 13, 2019
@debadair debadair deleted the 7.0-upgrade branch March 13, 2019 21:38
debadair added a commit that referenced this pull request Mar 13, 2019
@debadair
[DOCS] First pass at upgrade updates for 7.0. (#39944)
a3ef565 
* [DOCS] First pass at upgrade updates for 7.0.

* [DOCS] Updates X-Pack terminology

* [DOCS] Incorporated feedback from lcawl.
debadair added a commit that referenced this pull request Mar 13, 2019
@debadair
[DOCS] First pass at upgrade updates for 7.0. (#39944)
b091d18 
* [DOCS] First pass at upgrade updates for 7.0.

* [DOCS] Updates X-Pack terminology

* [DOCS] Incorporated feedback from lcawl.
@lcawl lcawl mentioned this pull request Mar 20, 2019
Open
16 tasks
This was referenced Apr 9, 2019
Closed
Closed
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl approved these changes

Assignees
No one assigned
Labels
:Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts >docs General docs changes Team:Delivery Meta label for Delivery team v7.0.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@debadair @elasticmachine @lcawl @mark-vieira @michaelbaamonde