Docs: Move id in the java-api #40748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
|
I'll have to backport this back to the beginning of time but it is simple enough.... |
|
I tested with the asciidoctor build too and it's successful. Thanks for fixing this! |
|
Thanks for reviewing @lcawl! |
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
nik9000
added a commit
that referenced
this pull request
Apr 2, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
|
Backport complete |
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Apr 3, 2019
…leniency * elastic/master: SQL: Fix deserialisation issue of TimeProcessor (elastic#40776) Improve GCS docs for using keystore (elastic#40605) Add Restore Operation to SnapshotResiliencyTests (elastic#40634) Small refactorings to analysis components (elastic#40745) SQL: Fix display size for DATE/DATETIME (elastic#40669) add HLRC protocol tests for transform state and stats (elastic#40766) Inline TransportReplAction#registerRequestHandlers (elastic#40762) remove experimental label from search_as_you_type documentation (elastic#40744) Remove some abstractions from `TransportReplicationAction` (elastic#40706) Upgrade to latest build scan plugin (elastic#40702) Use default memory lock setting in testing (elastic#40730) Add Bulk Delete Api to BlobStore (elastic#40322) Remove yaml skips older than 7.0 (elastic#40183) Docs: Move id in the java-api (elastic#40748)
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Moves the id of the preface in the java-api so it is compatible with both AsciiDoc and Asciidoctor. As it stands now we apply the id that we want for the preface to the book itself which is strange and only works with AsciiDoc.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the id of the preface in the java-api so it is compatible with
both AsciiDoc and Asciidoctor. As it stands now we apply the id that we
want for the preface to the book itself which is strange and only works
with AsciiDoc.
This doesn't change how asciidoc renders the docs. It is a noop except
for the compatibility.