Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relax Overly Strict Assertion in TransportShardBulkAction #40940

Merged
merged 3 commits into from
Apr 8, 2019
Merged

Relax Overly Strict Assertion in TransportShardBulkAction #40940

merged 3 commits into from
Apr 8, 2019

Commits on Apr 8, 2019

  1. Remove Overly Strict Assertion in TransportShardBulkAction 

    * In elastic#39793 this assertion was added under the assumption that no exceptions would be thrown in this method, which turned out not to be correct and at the very least `org.elasticsearch.index.shard.IndexShardClosedException` can be thrown by `org.elasticsearch.index.shard.IndexShard.sync`
* Closes elastic#40933
    @original-brownbear
    original-brownbear committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    7c3e3cc View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'elastic/master' into 40933

    @original-brownbear
    original-brownbear committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    be506ab View commit details
    Browse the repository at this point in the history

  3. safer finishRequest call

    @original-brownbear
    original-brownbear committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    26fcaed View commit details
    Browse the repository at this point in the history