SQL: fix *SecurityIT tests by covering edge case scenarios when audit file rolls over at midnight #41328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
but the audit rolling file rolls over. * Use a local boolean variable instead of the static one to account for assertBusy() code block possibly being called multiple times and having different execution paths.
astefan
added
>test
|
Pinging @elastic/es-search |
matriv
approved these changes
Apr 18, 2019
| @@ -188,6 +188,13 @@ public void setInitialAuditLogOffset() { | |||
| } catch (IOException e) { | |||
| throw new RuntimeException(e); | |||
| } | |||
|
|
|||
| // the log file can roll over without being catched by assertLogs() method: in those tests where exceptions are being handled | |||
astefan
added a commit
that referenced
this pull request
Apr 18, 2019
… file rolls over at midnight (#41328) * Handle the scenario where assertLogs() is not called from a test method but the audit rolling file rolls over. * Use a local boolean variable instead of the static one to account for assertBusy() code block possibly being called multiple times and having different execution paths. (cherry picked from commit 6f64219)
astefan
added a commit
that referenced
this pull request
Apr 18, 2019
… file rolls over at midnight (#41328) * Handle the scenario where assertLogs() is not called from a test method but the audit rolling file rolls over. * Use a local boolean variable instead of the static one to account for assertBusy() code block possibly being called multiple times and having different execution paths. (cherry picked from commit 6f64219)
astefan
added a commit
that referenced
this pull request
Apr 18, 2019
… file rolls over at midnight (#41328) * Handle the scenario where assertLogs() is not called from a test method but the audit rolling file rolls over. * Use a local boolean variable instead of the static one to account for assertBusy() code block possibly being called multiple times and having different execution paths. (cherry picked from commit 6f64219)
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
… file rolls over at midnight (elastic#41328) * Handle the scenario where assertLogs() is not called from a test method but the audit rolling file rolls over. * Use a local boolean variable instead of the static one to account for assertBusy() code block possibly being called multiple times and having different execution paths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes another edge case scenarios when audit file rolls over at midnight.
Fixes #39348.