New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description to force-merge tasks #41365
Add description to force-merge tasks #41365
Conversation
Pinging @elastic/es-core-features |
@elasticmachine test this please |
Thanks @centic9, this is a very useful enhancement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@centic9 I left one minor comment, do you want to address that?
Otherwise this looks good to me.
server/src/main/java/org/elasticsearch/action/admin/indices/forcemerge/ForceMergeRequest.java
Outdated
Show resolved
Hide resolved
test this please |
@elasticmachine update branch |
retest this please |
Thanks for your contribution and for addressing your PR based on the feedback @centic9 ! One more thing I would do is add a test so that we make sure we don't change this. A unit test that verifies the output of the new toString method would be enough for instance. Otherwise we may end up changing that one day without realizing what effect such change has. |
Thanks for the response @javanna, I have now added a test which verifies the contents of getDescription() with various different values. |
@elasticmachine test this please |
@centic9 Thanks for updating the PR and apologies for not getting back to you. |
This is static information that is part of the force merge request. Relates to elastic#15975
This is related to #15975 by providing at least some description for running force-merge tasks and thus allows to see which force-merges on which indices are running and which settings were provided.
With this PR applied, the Task API will look something like the following for a "GET /_tasks?detailed":
This does not provide progress-information, which would be very helpful for long-running merges to see how much longer they will approximately run, but this seems to be non-trivial to add, at least I could not find an easy way (hints for adding this are appreciated if there is a fairly simple approach for doing it!).