Geo: Add GeoJson parser to libs/geo classes #41575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds GeoJson parser for Geometry classes defined in libs/geo. This should allow us to bypass ShapeBuilders in geosql and is the first step in ShapeBuilder refactoring. The provided functionality should be sufficient for geosql parsing, but additional functionality will be required for complete parity with ShapeBuilder parser - we need to add handling of mapper parameters in WKT parser as well. That will be added in a follow up PR. Relates elastic#40908
imotov
added
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo |
|
@elasticmachine run elasticsearch-ci/1 |
1 similar comment
|
@elasticmachine run elasticsearch-ci/1 |
…bs-geo-geojson-parser
talevy
reviewed
Apr 26, 2019
| @@ -33,4 +35,8 @@ | |||
| LINEARRING, // not serialized by itself in WKT or WKB | |||
| ENVELOPE, // not part of the actual WKB spec | |||
| CIRCLE; // not part of the actual WKB spec | |||
|
|
|||
| public static ShapeType forName(String geoshapename) { | |||
There was a problem hiding this comment.
should we camelCase that variable name?
|
|
||
| @Override | ||
| public String visit(LinearRing ring) { | ||
| throw new UnsupportedOperationException("line ring cannot be serialized using GeoJson"); |
| /** | ||
| * Parses supplied XContent into Geometry | ||
| */ | ||
| static Geometry parse(XContentParser parser, BaseGeoShapeFieldMapper shapeMapper) throws IOException, ParseException { |
There was a problem hiding this comment.
It would be great to remove the dependency on a field mapper here. maybe require the three attributes explicitly
talevy
approved these changes
Apr 29, 2019
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Apr 29, 2019
Adds GeoJson parser for Geometry classes defined in libs/geo. Relates elastic#40908 and elastic#29872
imotov
added a commit
that referenced
this pull request
Apr 29, 2019
akhil10x5
pushed a commit
to akhil10x5/elasticsearch
that referenced
this pull request
May 2, 2019
Adds GeoJson parser for Geometry classes defined in libs/geo. Relates elastic#40908 and elastic#29872
gurkankaymak
pushed a commit
to gurkankaymak/elasticsearch
that referenced
this pull request
May 27, 2019
Adds GeoJson parser for Geometry classes defined in libs/geo. Relates elastic#40908 and elastic#29872
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds GeoJson parser for Geometry classes defined in libs/geo. This
should allow us to bypass ShapeBuilders in geosql and is the first
step in ShapeBuilder refactoring. The provided functionality should
be sufficient for geosql parsing, but additional functionality will
be required for complete parity with ShapeBuilder parser - we need
to add handling of mapper parameters in WKT parser as well. That
will be added in a follow up PR.
Relates #40908 and #29872