Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test to verify force primary allocation on closed indices #42458

Merged
merged 3 commits into from
May 24, 2019
Merged

Add test to verify force primary allocation on closed indices #42458

merged 3 commits into from
May 24, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented May 23, 2019

This change adds a test verifying that we can force primary allocation on closed indices.

Relates #33888

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. v8.0.0 v7.2.0 v7.3.0 labels May 23, 2019
@dnhatn dnhatn requested a review from ywelsch May 23, 2019 18:51
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@tlrx tlrx mentioned this pull request May 23, 2019
Closed
50 tasks
@ywelsch
Copy link
Contributor

ywelsch commented May 23, 2019

Can you also add a test for force-allocating an empty (closed) primary?

@dnhatn
Copy link
Member Author

dnhatn commented May 23, 2019

@ywelsch

boolean useStaleReplica = randomBoolean(); // if true, use stale replica, otherwise a completely empty copy

This test randomly allocates a stale replica or an empty copy. Are you okay with this? I can add a new test.

ywelsch
ywelsch approved these changes May 23, 2019
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed that :)

@dnhatn
Copy link
Member Author

dnhatn commented May 24, 2019

Thanks @ywelsch.

@dnhatn dnhatn merged commit cd324a1 into elastic:master May 24, 2019
@dnhatn dnhatn deleted the force-alloc-closed-indices branch May 24, 2019 15:19
ywelsch pushed a commit that referenced this pull request May 24, 2019
@dnhatn @ywelsch
Add test to verify force primary allocation on closed indices (#42458)
329d130 
This change adds a test verifying that we can force primary allocation on closed indices.
ywelsch pushed a commit that referenced this pull request May 24, 2019
@dnhatn @ywelsch
Add test to verify force primary allocation on closed indices (#42458)
277df27 
This change adds a test verifying that we can force primary allocation on closed indices.
ywelsch pushed a commit that referenced this pull request May 24, 2019
@dnhatn @ywelsch
Add test to verify force primary allocation on closed indices (#42458)
20ad899 
This change adds a test verifying that we can force primary allocation on closed indices.
dnhatn added a commit that referenced this pull request May 24, 2019
@dnhatn
Revert "Add test to verify force primary allocation on closed indices (…
cfa72d1 
…#42458)"

Replicate closed indices requires 7.2.0 or later.
This reverts commit 20ad899.
gurkankaymak pushed a commit to gurkankaymak/elasticsearch that referenced this pull request May 27, 2019
@dnhatn
Add test to verify force primary allocation on closed indices (elasti…
82c2b9e 
…c#42458)

This change adds a test verifying that we can force primary allocation on closed indices.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywelsch ywelsch ywelsch approved these changes

Assignees
No one assigned
Labels
:Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >test Issues or PRs that are addressing/adding tests v7.2.0 v7.3.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dnhatn @elasticmachine @ywelsch @jakelandis