Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PreConfiguredTokenFilters getSynonymFilter() implementations #43678

Merged
merged 2 commits into from Jun 28, 2019
Merged

Fix PreConfiguredTokenFilters getSynonymFilter() implementations #43678

merged 2 commits into from Jun 28, 2019

Commits on Jun 27, 2019

  1. Fix PreConfiguredTokenFilters getSynonymFilter() implementations (ela… 

    …stic#38839)

When we added support for TokenFilterFactories to specialise how they were used when parsing
synonym files, PreConfiguredTokenFilters were set up to either apply themselves, or be ignored.
This behaviour is a leftover from an earlier iteration, and also has an incorrect default.

This commit makes preconfigured token filters usable in synonym file parsing by default, and brings
those filters that should not be used into line with index-specific filter factories; in indexes created
before version 7 we emit a deprecation warning, and we throw an error in indexes created after.

Fixes elastic#38793
    @romseygeek
    romseygeek committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    521f53f View commit details
    Browse the repository at this point in the history

  2. Merge branch '7.x' into preconfigured-synonyms-backport

    @elasticmachine
    elasticmachine committed Jun 27, 2019
    Configuration menu
    Copy the full SHA
    ab5fecc View commit details
    Browse the repository at this point in the history