Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wildcard intervals #43691

Merged
merged 7 commits into from Jun 28, 2019
Merged

Wildcard intervals #43691

merged 7 commits into from Jun 28, 2019

Conversation

romseygeek
Copy link
Contributor

@romseygeek romseygeek commented Jun 27, 2019

This commit adds a wildcard intervals source, similar to the prefix. It
also changes the term parameter in prefix to read prefix, to bring it
in to line with the pattern parameter in wildcard.

Closes #43198

@romseygeek romseygeek added >feature :Search/Search Search-related issues that do not fall into other categories v8.0.0 v7.3.0 labels Jun 27, 2019
@romseygeek romseygeek requested a review from jimczi June 27, 2019 11:08
@romseygeek romseygeek self-assigned this Jun 27, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@romseygeek
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/default-distro

Copy link
Contributor

@jimczi jimczi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM, I left a comment regarding the docs


[horizontal]
`pattern`::
Match terms starting matching this pattern
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the operators that are supported (? and * ?) and maybe a warning regarding leading wildcards ?

@romseygeek
Copy link
Contributor Author

@elasticmachine update branch

@romseygeek romseygeek merged commit 89a3eb3 into elastic:master Jun 28, 2019
romseygeek added a commit that referenced this pull request Jun 28, 2019
This commit adds a wildcard intervals source, similar to the prefix. It
also changes the term parameter in prefix to read prefix, to bring it
in to line with the pattern parameter in wildcard.

Closes #43198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>feature :Search/Search Search-related issues that do not fall into other categories v7.3.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add wildcard and prefix intervals
4 participants