AsyncIOProcessor preserve thread context #43729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AsyncIOProcessor now preserves thread context, ensuring that deprecation warnings are not duplicated to other concurrent operations on the same shard.
henningandersen
added
>bug
:Distributed/Engine
|
Pinging @elastic/es-distributed |
ywelsch
approved these changes
Jun 28, 2019
| @@ -121,6 +123,16 @@ private void processList(List<Tuple<Item, Consumer<Exception>>> candidates) { | |||
| } | |||
| } | |||
|
|
|||
| private Consumer<Exception> preserveContext(Consumer<Exception> consumer) { | |||
| ThreadContext.StoredContext storedContext = threadContext.newStoredContext(false); | |||
There was a problem hiding this comment.
perhaps use threadContext.newRestorableContext(false). It's simpler.
There was a problem hiding this comment.
Thanks, fixed here: acfa0d6
|
@elasticmachine run elasticsearch-ci/default-distro |
henningandersen
added a commit
that referenced
this pull request
Jul 3, 2019
AsyncIOProcessor now preserves thread context, ensuring that deprecation warnings are not duplicated to other concurrent operations on the same shard.
henningandersen
added a commit
that referenced
this pull request
Jul 3, 2019
AsyncIOProcessor now preserves thread context, ensuring that deprecation warnings are not duplicated to other concurrent operations on the same shard.
henningandersen
added a commit
that referenced
this pull request
Jul 3, 2019
AsyncIOProcessor now preserves thread context, ensuring that deprecation warnings are not duplicated to other concurrent operations on the same shard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AsyncIOProcessor now preserves thread context, ensuring that deprecation
warnings are not duplicated to other concurrent operations on the same
shard.