Simplify indices stats API #4382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@spinscale shouldn't this include the documentation changes since this is a breaking change? |
|
@dakrone totally. changed docs as well |
Note: This breaks backward compatibility * Removed clear/all parameters, now all stats are returned by default * Made the metrics part of the URL * Removed a lot of handlers * Added shards/indices/cluster level paremeter to change response serialization * Returning translog statistics in IndicesStats * Added TranslogStats class * Added IndexShard.translogStats() method to get the stats from concrete implementation * Updated documentation Closes elastic#4054
|
@spinscale does this change the response format for previously returned stats or just parameters? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This breaks backward compatibility
Closes #4054