Update BWC version for PRRLs #43958
Merged
Update BWC version for PRRLs #43958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit updates the version in which PRRLs are expected to exist to 7.4.0.
DaveCTurner
added
>non-issue
:Distributed/Recovery
|
Pinging @elastic/es-distributed |
DaveCTurner
requested review from
dnhatn and
ywelsch
and removed request for
dnhatn
DaveCTurner
commented
Jul 4, 2019
| @@ -7,5 +7,6 @@ | |||
| ES_BUILD_JAVA=openjdk12 | |||
| ES_RUNTIME_JAVA=java11 | |||
| GRADLE_TASK=build | |||
| GRADLE_EXTRA_ARGS=-Dtests.bwc.refspec.7.x=peer-recovery-retention-leases-7.x | |||
There was a problem hiding this comment.
There's a risk that we forget to remove this when we merge these branches to master. The consequence will be that master builds start to use peer-recovery-retention-leases-7.x rather than 7.x, which will fail when:
- we delete the
peer-recovery-retention-leases-7.x, or - we introduce a BWC-affecting change to
masterand7.x(but, of course not topeer-recovery-retention-leases-7.x)
I think we'll catch this mistake pretty quickly, but if it's a concern then ideas for machinery to fail the build sooner are welcome.
ywelsch
approved these changes
Jul 4, 2019
| @@ -7,5 +7,6 @@ | |||
| ES_BUILD_JAVA=openjdk12 | |||
| ES_RUNTIME_JAVA=java11 | |||
| GRADLE_TASK=build | |||
| GRADLE_EXTRA_ARGS=-Dtests.bwc.refspec.7.x=peer-recovery-retention-leases-7.x | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the version in which PRRLs are expected to exist to 7.4.0.
See #43959 for the 7.x version of this.