Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent types deprecation warning for indices.exists requests #43963

Merged

Conversation

@cbuescher
Copy link
Member

commented Jul 4, 2019

Currently we log a deprecation warning to the types removal in
RestGetIndicesAction even if the REST method is HEAD, which is used by the
indices.exists API. Since the body is empty in this case we should not show
the deprecation warning.

Closes #43905

Currently we log a deprecation warning to the types removal in
RestGetIndicesAction even if the REST method is HEAD, which is used by the
indices.exists API. Since the body is empty in this case we should not need to
show the deprecation warning.

Closes #43905
@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jul 4, 2019

@cbuescher

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

@elasticmachine run elasticsearch-ci/2

1 similar comment
@cbuescher

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

@elasticmachine run elasticsearch-ci/2

Copy link
Member

left a comment

Looks good to me!

@cbuescher cbuescher merged commit a19551a into elastic:master Jul 4, 2019
8 checks passed
8 checks passed
CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details
@cbuescher

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

@jtibshirani thanks, will backport to the active 7.x branches and 6.8 where I think its mostly needed

cbuescher added a commit that referenced this pull request Jul 4, 2019
Currently we log a deprecation warning to the types removal in
RestGetIndicesAction even if the REST method is HEAD, which is used by the
indices.exists API. Since the body is empty in this case we should not need to
show the deprecation warning.

Closes #43905
cbuescher added a commit that referenced this pull request Jul 4, 2019
Currently we log a deprecation warning to the types removal in
RestGetIndicesAction even if the REST method is HEAD, which is used by the
indices.exists API. Since the body is empty in this case we should not need to
show the deprecation warning.

Closes #43905
cbuescher added a commit that referenced this pull request Jul 4, 2019
Currently we log a deprecation warning to the types removal in
RestGetIndicesAction even if the REST method is HEAD, which is used by the
indices.exists API. Since the body is empty in this case we should not need to
show the deprecation warning.

Closes #43905
cbuescher added a commit to cbuescher/elasticsearch that referenced this pull request Jul 4, 2019
…c#43963)

Currently we log a deprecation warning to the types removal in
RestGetIndicesAction even if the REST method is HEAD, which is used by the
indices.exists API. Since the body is empty in this case we should not need to
show the deprecation warning.

Closes elastic#43905
cbuescher added a commit to cbuescher/elasticsearch that referenced this pull request Jul 4, 2019
…c#43963)

Currently we log a deprecation warning to the types removal in
RestGetIndicesAction even if the REST method is HEAD, which is used by the
indices.exists API. Since the body is empty in this case we should not need to
show the deprecation warning.

Closes elastic#43905
cbuescher added a commit that referenced this pull request Jul 4, 2019
Currently we log a deprecation warning to the types removal in
RestGetIndicesAction even if the REST method is HEAD, which is used by the
indices.exists API. Since the body is empty in this case we should not need to
show the deprecation warning.

Closes #43905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.