Prevent types deprecation warning for indices.exists requests #43963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we log a deprecation warning to the types removal in RestGetIndicesAction even if the REST method is HEAD, which is used by the indices.exists API. Since the body is empty in this case we should not need to show the deprecation warning. Closes elastic#43905
cbuescher
added
>bug
:Search Foundations/Mapping
|
Pinging @elastic/es-search |
|
@elasticmachine run elasticsearch-ci/2 |
1 similar comment
|
@elasticmachine run elasticsearch-ci/2 |
|
@jtibshirani thanks, will backport to the active 7.x branches and 6.8 where I think its mostly needed |
cbuescher
pushed a commit
that referenced
this pull request
Jul 4, 2019
Currently we log a deprecation warning to the types removal in RestGetIndicesAction even if the REST method is HEAD, which is used by the indices.exists API. Since the body is empty in this case we should not need to show the deprecation warning. Closes #43905
cbuescher
pushed a commit
that referenced
this pull request
Jul 4, 2019
Currently we log a deprecation warning to the types removal in RestGetIndicesAction even if the REST method is HEAD, which is used by the indices.exists API. Since the body is empty in this case we should not need to show the deprecation warning. Closes #43905
cbuescher
pushed a commit
that referenced
this pull request
Jul 4, 2019
Currently we log a deprecation warning to the types removal in RestGetIndicesAction even if the REST method is HEAD, which is used by the indices.exists API. Since the body is empty in this case we should not need to show the deprecation warning. Closes #43905
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Jul 4, 2019
…c#43963) Currently we log a deprecation warning to the types removal in RestGetIndicesAction even if the REST method is HEAD, which is used by the indices.exists API. Since the body is empty in this case we should not need to show the deprecation warning. Closes elastic#43905
cbuescher
pushed a commit
that referenced
this pull request
Jul 4, 2019
Currently we log a deprecation warning to the types removal in RestGetIndicesAction even if the REST method is HEAD, which is used by the indices.exists API. Since the body is empty in this case we should not need to show the deprecation warning. Closes #43905
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we log a deprecation warning to the types removal in
RestGetIndicesAction even if the REST method is HEAD, which is used by the
indices.exists API. Since the body is empty in this case we should not show
the deprecation warning.
Closes #43905