Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Data frame task failure do not make a 500 response #44058

Merged
merged 1 commit into from Jul 8, 2019

Conversation

@davidkyle
Copy link
Member

commented Jul 8, 2019

Data frame task responses had logic to return a HTTP 500 status code if there was node or task failure even if other tasks in the same request reported correctly. This is different to how other task responses are handled where a 200 is returned and the client should check for failures. Remove the BaseTasksResponseToXContentListener class added to handle data frame tasks responses.

If the high level rest client encounters a 500 status it tries to parse the response as an exception, this will fail for a task responses.

Closes #44011

@elasticmachine

This comment has been minimized.

Copy link
Collaborator

commented Jul 8, 2019

Copy link
Contributor

left a comment

LGTM

@davidkyle davidkyle merged commit 8fd5d76 into elastic:master Jul 8, 2019
8 checks passed
8 checks passed
CLA All commits in pull request signed
Details
elasticsearch-ci/1 Build finished.
Details
elasticsearch-ci/2 Build finished.
Details
elasticsearch-ci/bwc Build finished.
Details
elasticsearch-ci/default-distro Build finished.
Details
elasticsearch-ci/docbldesx Build finished.
Details
elasticsearch-ci/oss-distro-docs Build finished.
Details
elasticsearch-ci/packaging-sample Build finished.
Details
@davidkyle davidkyle deleted the davidkyle:df-tasks-not-an-error branch Jul 8, 2019
davidkyle added a commit that referenced this pull request Jul 8, 2019
Data frame task responses had logic to return a HTTP 500 status code if there was 
any node or task failures even if other tasks in the same request reported correctly. 
This is different to how other task responses are handled where a 200 is always 
returned leaving the client should check for failures. Returning a 500 also breaks
the high level rest client so always return a 200

Closes #44011
davidkyle added a commit that referenced this pull request Jul 8, 2019
Data frame task responses had logic to return a HTTP 500 status code if there was 
any node or task failures even if other tasks in the same request reported correctly. 
This is different to how other task responses are handled where a 200 is always 
returned leaving the client should check for failures. Returning a 500 also breaks
the high level rest client so always return a 200

Closes #44011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.