Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not use mock engine in PrimaryAllocationIT #44083

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Do not use mock engine in PrimaryAllocationIT #44083

merged 1 commit into from
Jul 9, 2019

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jul 8, 2019 •
edited
Loading

PrimaryAllocationIT#testForceStaleReplicaToBePromotedToPrimary relies on the flushing when a shard is no long assigned. This behavior, however, can be randomly disabled in MockInternalEngine.

Closes #44049

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. v8.0.0 v7.3.0 v7.2.1 v7.4.0 labels Jul 8, 2019
@dnhatn dnhatn requested a review from ywelsch July 8, 2019 17:37
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

ywelsch
ywelsch approved these changes Jul 8, 2019
View reviewed changes
Copy link
Contributor

@ywelsch ywelsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dnhatn
Copy link
Member Author

dnhatn commented Jul 9, 2019

@elasticmachine test this please

@dnhatn
Copy link
Member Author

dnhatn commented Jul 9, 2019

unrelated test failure
@elasticmachine run elasticsearch-ci/2

@dnhatn
Copy link
Member Author

dnhatn commented Jul 9, 2019

Thanks @ywelsch.

@dnhatn dnhatn merged commit dbe8d64 into elastic:master Jul 9, 2019
@dnhatn dnhatn deleted the alloc-close-stale-copy branch July 9, 2019 13:52
dnhatn added a commit that referenced this pull request Jul 10, 2019
@dnhatn
Do not use mock engine in PrimaryAllocationIT (#44083)
b158919 
PrimaryAllocationIT#testForceStaleReplicaToBePromotedToPrimary 
relies on the flushing when a shard is no long assigned. This behavior,
however, can be randomly disabled in MockInternalEngine.

Closes #44049
dnhatn added a commit that referenced this pull request Jul 14, 2019
@dnhatn
Do not use mock engine in PrimaryAllocationIT (#44083)
9ee7062 
PrimaryAllocationIT#testForceStaleReplicaToBePromotedToPrimary 
relies on the flushing when a shard is no long assigned. This behavior,
however, can be randomly disabled in MockInternalEngine.

Closes #44049
dnhatn added a commit that referenced this pull request Jul 14, 2019
@dnhatn
Do not use mock engine in PrimaryAllocationIT (#44083)
e55728b 
PrimaryAllocationIT#testForceStaleReplicaToBePromotedToPrimary 
relies on the flushing when a shard is no long assigned. This behavior,
however, can be randomly disabled in MockInternalEngine.

Closes #44049
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywelsch ywelsch ywelsch approved these changes

Assignees
No one assigned
Labels
:Distributed/Distributed A catch all label for anything in the Distributed Area. If you aren't sure, use this one. >test Issues or PRs that are addressing/adding tests v7.2.1 v7.3.0 v7.4.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PrimaryAllocationIT#testForceStaleReplicaToBePromotedToPrimary fails
4 participants
@dnhatn @elasticmachine @ywelsch @jakelandis