-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Fix custom timestamp override with dot-separated fractional seconds #44127
[ML] Fix custom timestamp override with dot-separated fractional seconds #44127
Conversation
Custom timestamp overrides provided to the find_file_structure endpoint produced an invalid Grok pattern if the fractional seconds separator was a dot rather than a comma or colon. This commit fixes that problem and adds tests for this sort of timestamp override. Fixes elastic#44110
Pinging @elastic/ml-core |
This is marked |
I moved it to |
Given that the current process (from the email with subject "Blockers and preparing for releases") is "For minor releases we will switch to a model where we produce a build candidate once per week up to the last which we will do 72 business hours before the release date" it seems to me that all this relabelling is just creating work. Someone will now have to change the label back when this is merged. Surely it would be easier if bug fixes merged well before that final build candidate for a minor were just labelled with that minor version? |
I agree it is extra work. I tend to like the fact that it gives us more flexibility with moving dates and doesn't require everyone to follow the release process too closely. I'll start a discussion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Custom timestamp overrides provided to the find_file_structure
endpoint produced an invalid Grok pattern if the fractional
seconds separator was a dot rather than a comma or colon.
This commit fixes that problem and adds tests for this sort
of timestamp override.
Fixes #44110