Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Fix custom timestamp override with dot-separated fractional seconds #44127

Merged

Conversation

droberts195
Copy link
Contributor

Custom timestamp overrides provided to the find_file_structure
endpoint produced an invalid Grok pattern if the fractional
seconds separator was a dot rather than a comma or colon.
This commit fixes that problem and adds tests for this sort
of timestamp override.

Fixes #44110

Custom timestamp overrides provided to the find_file_structure
endpoint produced an invalid Grok pattern if the fractional
seconds separator was a dot rather than a comma or colon.
This commit fixes that problem and adds tests for this sort
of timestamp override.

Fixes elastic#44110
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@droberts195
Copy link
Contributor Author

This is marked >non-issue even though it's a bug because it was both introduced and fixed in 7.3.0, so does not need to be release noted.

@jpountz
Copy link
Contributor

jpountz commented Jul 10, 2019

I moved it to v7.3.1.

@droberts195
Copy link
Contributor Author

Given that the current process (from the email with subject "Blockers and preparing for releases") is "For minor releases we will switch to a model where we produce a build candidate once per week up to the last which we will do 72 business hours before the release date" it seems to me that all this relabelling is just creating work. Someone will now have to change the label back when this is merged. Surely it would be easier if bug fixes merged well before that final build candidate for a minor were just labelled with that minor version?

@jpountz
Copy link
Contributor

jpountz commented Jul 10, 2019

I agree it is extra work. I tend to like the fact that it gives us more flexibility with moving dates and doesn't require everyone to follow the release process too closely. I'll start a discussion.

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195 droberts195 merged commit bca4edc into elastic:master Jul 10, 2019
@droberts195 droberts195 deleted the fix_custom_timestamp_override_frac_secs branch July 10, 2019 09:26
droberts195 added a commit that referenced this pull request Jul 10, 2019
…nds (#44127)

Custom timestamp overrides provided to the find_file_structure
endpoint produced an invalid Grok pattern if the fractional
seconds separator was a dot rather than a comma or colon.
This commit fixes that problem and adds tests for this sort
of timestamp override.

Fixes #44110
droberts195 added a commit that referenced this pull request Jul 10, 2019
…nds (#44127)

Custom timestamp overrides provided to the find_file_structure
endpoint produced an invalid Grok pattern if the fractional
seconds separator was a dot rather than a comma or colon.
This commit fixes that problem and adds tests for this sort
of timestamp override.

Fixes #44110
@jpountz jpountz added v7.3.0 and removed v7.3.1 labels Jul 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] File Data Visualizer - error on certain custom timestamp formats
5 participants