New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML][Data Frame] prevent task from attempting to run when failed #44239
Merged
benwtrent
merged 2 commits into
elastic:master
from
benwtrent:bug/ml-df-dont-start-failed-task-on-node-start
Jul 12, 2019
Merged
[ML][Data Frame] prevent task from attempting to run when failed #44239
benwtrent
merged 2 commits into
elastic:master
from
benwtrent:bug/ml-df-dont-start-failed-task-on-node-start
Jul 12, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/ml-core |
hendrikmuhs
approved these changes
Jul 12, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
run elasticsearch-ci/bwc |
run elasticsearch-ci/default-distro |
@elasticmachine update branch |
run elasticsearch-ci/2 |
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Jul 12, 2019
benwtrent
added a commit
that referenced
this pull request
Jul 12, 2019
polyfractal
pushed a commit
to polyfractal/elasticsearch
that referenced
this pull request
Jul 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to how we handle the failed state for anomaly detector jobs, we should not allow the task to execute if it is failed. The failure could have been unrecoverable, or due to cluster load but we have no accurate way to determine this. Consequently, the failed task should not start if it gets assigned to a different node.
closes #44121