Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML][Data Frame] prevent task from attempting to run when failed #44239

Conversation

benwtrent
Copy link
Member

Similar to how we handle the failed state for anomaly detector jobs, we should not allow the task to execute if it is failed. The failure could have been unrecoverable, or due to cluster load but we have no accurate way to determine this. Consequently, the failed task should not start if it gets assigned to a different node.

closes #44121

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

Copy link
Contributor

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidkyle
Copy link
Member

run elasticsearch-ci/bwc

@davidkyle
Copy link
Member

run elasticsearch-ci/default-distro

@benwtrent
Copy link
Member Author

@elasticmachine update branch

@benwtrent
Copy link
Member Author

run elasticsearch-ci/2

@benwtrent benwtrent merged commit 0947114 into elastic:master Jul 12, 2019
@benwtrent benwtrent deleted the bug/ml-df-dont-start-failed-task-on-node-start branch July 12, 2019 17:58
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Jul 12, 2019
polyfractal pushed a commit to polyfractal/elasticsearch that referenced this pull request Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ML] Failed data frame transform is restarted when the node restarts
5 participants