Treat big changes in searchCount as significant and persist the document after such changes #44413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent after such changes
|
Pinging @elastic/ml-core |
przemekwitek
added a commit
to przemekwitek/elasticsearch
that referenced
this pull request
Jul 16, 2019
…ent after such changes (elastic#44413)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if the total search time doesn't change because searches are lightning-fast (i.e. take 0ms), the
datafeed timing stats are never persisted. This might have caused DatafeedJobIT.java test failures as the tests expect the searchCount to always increase after datafeed had done its job.
This PR aims to fix that by recognizing changes made to searchCount and persisting the datafeed timing stats should the searchCount changed significantly.
Related to: #44335, #44196