Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrate more ML actions off of using Request suppliers #44462

Merged
merged 7 commits into from
Jul 17, 2019

Conversation

talevy
Copy link
Contributor

@talevy talevy commented Jul 16, 2019

many classes still use the Streamable constructors of HandledTransportAction,
this commit moves more of those classes to the new Writeable constructors.

relates #34389.

many classes still use the Streamable constructors of HandledTransportAction,
this commit moves more of those classes to the new Writeable constructors.

relates elastic#34389.
@talevy talevy added :Core/Infra/Core Core issues without another label >refactoring v8.0.0 v7.4.0 labels Jul 16, 2019
@talevy talevy requested a review from rjernst July 16, 2019 22:13
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@talevy
Copy link
Contributor Author

talevy commented Jul 17, 2019

run elasticsearch-ci/packaging-sample

@talevy
Copy link
Contributor Author

talevy commented Jul 17, 2019

@elasticmachine test this please

@rjernst rjernst merged commit e854a19 into elastic:master Jul 17, 2019
@talevy talevy deleted the migratemoreml branch July 17, 2019 23:47
talevy added a commit to talevy/elasticsearch that referenced this pull request Jul 17, 2019
many classes still use the Streamable constructors of HandledTransportAction,
this commit moves more of those classes to the new Writeable constructors.

relates elastic#34389.
talevy added a commit that referenced this pull request Jul 18, 2019
many classes still use the Streamable constructors of HandledTransportAction,
this commit moves more of those classes to the new Writeable constructors.

relates #34389.
polyfractal pushed a commit to polyfractal/elasticsearch that referenced this pull request Jul 29, 2019
many classes still use the Streamable constructors of HandledTransportAction,
this commit moves more of those classes to the new Writeable constructors.

relates elastic#34389.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants