[ML-DataFrame] Remove ID field from data frame indexer stats #44768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a followup to elastic#44350. The indexer stats used to be persisted standalone, but now are only persisted as part of a state-and-stats document. During the review of elastic#44350 it was decided that we'll stick with this design, so there will never be a need for an indexer stats object to store its transform ID as it is stored on the enclosing document. This PR removes the indexer stats document ID.
|
Pinging @elastic/ml-core |
|
Jenkins run elasticsearch-ci/2 |
hendrikmuhs
approved these changes
Jul 23, 2019
| @@ -57,60 +55,46 @@ | |||
| LENIENT_PARSER.declareLong(constructorArg(), SEARCH_FAILURES); | |||
| } | |||
|
|
|||
| private final String transformId; | |||
|
|
|||
| /** | |||
| * Certain situations call for a default transform ID, e.g. when merging many different transforms for statistics gather. | |||
There was a problem hiding this comment.
nit: these comments aren't true anymore
There was a problem hiding this comment.
I removed the method as well as the comment as after the other changes I don't think it was adding much over calling the default constructor.
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jul 25, 2019
Mutes data frame BWC tests prior to backporting elastic#44768
droberts195
added a commit
that referenced
this pull request
Jul 25, 2019
Mutes data frame BWC tests prior to backporting #44768
droberts195
added a commit
that referenced
this pull request
Jul 25, 2019
This is a followup to #44350. The indexer stats used to be persisted standalone, but now are only persisted as part of a state-and-stats document. During the review of #44350 it was decided that we'll stick with this design, so there will never be a need for an indexer stats object to store its transform ID as it is stored on the enclosing document. This PR removes the indexer stats document ID. Backport of #44768
droberts195
added a commit
that referenced
this pull request
Jul 25, 2019
polyfractal
pushed a commit
to polyfractal/elasticsearch
that referenced
this pull request
Jul 29, 2019
…#44768) This is a followup to elastic#44350. The indexer stats used to be persisted standalone, but now are only persisted as part of a state-and-stats document. During the review of elastic#44350 it was decided that we'll stick with this design, so there will never be a need for an indexer stats object to store its transform ID as it is stored on the enclosing document. This PR removes the indexer stats document ID.
polyfractal
pushed a commit
to polyfractal/elasticsearch
that referenced
this pull request
Jul 29, 2019
Mutes data frame BWC tests prior to backporting elastic#44768
polyfractal
pushed a commit
to polyfractal/elasticsearch
that referenced
this pull request
Jul 29, 2019
…c#44852) This change adjusts the changes of elastic#44768 to account for the backport to the 7.x branch in elastic#44848.
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
Mutes data frame BWC tests prior to backporting #44768
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #44350. The indexer stats used to
be persisted standalone, but now are only persisted as
part of a state-and-stats document. During the review
of #44350 it was decided that we'll stick with this
design, so there will never be a need for an indexer
stats object to store its transform ID as it is stored
on the enclosing document. This PR removes the indexer
stats document ID.