Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore behavior for force parameter #44847

Merged
merged 3 commits into from
Jul 26, 2019
Merged

Restore behavior for force parameter #44847

merged 3 commits into from
Jul 26, 2019

Commits on Jul 25, 2019

  1. Restore behavior for force paramater 

    Turns out that the behavior of `-f` for the add and add-file sub
commands where it would also forcibly create the keystore if it
didn't exist, was by design - although undocumented.
This change restores that behavior auto-creating a keystore that
is not password protected if the force flag is used. The force
OptionSpec is moved to the BaseKeyStoreCommand as we will presumably
want to maintain the same behavior in any other command that takes
a force option
    @jkakavas
    jkakavas committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    cbd1ed5 View commit details
    Browse the repository at this point in the history

  2. cleanup

    @jkakavas
    jkakavas committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    f95bacc View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/feature-pwd-protected-keystore' … 

    …into restore-force-behavior
    @jkakavas
    jkakavas committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    9a65d8d View commit details
    Browse the repository at this point in the history