Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Indicate that some user APIs handle built-in users #44857

Merged
merged 2 commits into from
Jul 31, 2019
Merged

Indicate that some user APIs handle built-in users #44857

merged 2 commits into from
Jul 31, 2019

Conversation

jkakavas
Copy link
Member

@jkakavas jkakavas commented Jul 25, 2019 •
edited
Loading

The get users API also returns users form the restricted realm or built-in users, as we call them in our docs

@jkakavas
Indicate the get users API returns built-in users
31dc30c 
The get users API also returns users form the restricted realm or built-in users, as we call them in our docs
@jkakavas jkakavas added >docs General docs changes :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) labels Jul 25, 2019
@jkakavas jkakavas requested a review from lcawl July 25, 2019 14:01
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

lcawl
lcawl approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@jkakavas jkakavas requested a review from lcawl July 26, 2019 13:44
@jkakavas
Copy link
Member Author

@lcawl , I made the relevant change for the change password API also in this PR - instead of raising a new one

@jkakavas jkakavas changed the title Indicate the get users API returns built-in users Indicate that some user APIs handle built-in users Jul 26, 2019
@jkakavas
Copy link
Member Author

unrelated failures:

Test Result (2 failures / +1)

    org.elasticsearch.upgrades.UpgradeClusterClientYamlTestSuiteIT.test {p0=mixed_cluster/30_ml_jobs_crud/Test get old cluster job}
    org.elasticsearch.upgrades.UpgradeClusterClientYamlTestSuiteIT.test {p0=mixed_cluster/30_ml_jobs_crud/Test get old cluster categorization job}

@elasticmachine run elasticsearch-ci/bwc

@jkakavas jkakavas merged commit bbfa7aa into master Jul 31, 2019
jkakavas added a commit that referenced this pull request Jul 31, 2019
@jkakavas
Indicate that some user APIs handle built-in users (#44857)
56da35b 
The Get Users API also returns users form the restricted realm or built-in users,
 as we call them in our docs. One can also change the passwords of built-in 
users with the Change Password API
jkakavas added a commit that referenced this pull request Jul 31, 2019
@jkakavas
Indicate that some user APIs handle built-in users (#44857)
2ed412c 
The Get Users API also returns users form the restricted realm or built-in users,
 as we call them in our docs. One can also change the passwords of built-in 
users with the Change Password API
jkakavas added a commit that referenced this pull request Jul 31, 2019
@jkakavas
Indicate that some user APIs handle built-in users (#44857)
618ed11 
The Get Users API also returns users form the restricted realm or built-in users,
 as we call them in our docs. One can also change the passwords of built-in 
users with the Change Password API
@jkakavas jkakavas deleted the jkakavas-patch-1 branch July 31, 2019 14:57
jkakavas added a commit that referenced this pull request Jul 31, 2019
@jkakavas
Indicate that some user APIs handle built-in users (#44857)
7fcdb41 
The Get Users API also returns users form the restricted realm or built-in users,
 as we call them in our docs. One can also change the passwords of built-in 
users with the Change Password API
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl Awaiting requested review from lcawl

Assignees
No one assigned
Labels
>docs General docs changes :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jkakavas @elasticmachine @lcawl