Fix Snapshot CLI Build Portability #44919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The snapshot CLI tool does not use the `java` in `JAVA_HOME` but instead uses it from the `PATH` which will lead to some portability issues with the wrong `java` being used as the ES build itself does allow for having a different `java` than what is in `JAVA_HOME` on the `PATH`
original-brownbear
added
>non-issue
:Distributed/Snapshot/Restore
|
Pinging @elastic/es-distributed |
|
Jenkins run elasticsearch-ci/2 |
andrershov
approved these changes
Jul 29, 2019
There was a problem hiding this comment.
LGTM, would be nice to confirm that the fix works fine for @imotov
imotov
approved these changes
Jul 29, 2019
|
Thanks @andrershov and @imotov ! |
andrershov
pushed a commit
to andrershov/elasticsearch
that referenced
this pull request
Jul 29, 2019
The snapshot CLI tool does not use the `java` in `JAVA_HOME` but instead uses it from the `PATH` which will lead to some portability issues with the wrong `java` being used as the ES build itself does allow for having a different `java` than what is in `JAVA_HOME` on the `PATH` (cherry picked from commit 21fb690)
jkakavas
pushed a commit
that referenced
this pull request
Jul 31, 2019
The snapshot CLI tool does not use the `java` in `JAVA_HOME` but instead uses it from the `PATH` which will lead to some portability issues with the wrong `java` being used as the ES build itself does allow for having a different `java` than what is in `JAVA_HOME` on the `PATH`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The snapshot CLI tool does not use the
javainJAVA_HOMEbut instead uses it from thePATHwhich will lead to some portability issues with the wrongjavabeing used as the ES build itself does allow for having a differentjavathan what is inJAVA_HOMEon thePATH.For the discussion here #44551 (comment)