Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary plugin application and project configuration #45100

Merged
merged 1 commit into from Aug 1, 2019

Conversation

mark-vieira
Copy link
Contributor

In scenarios where we have a Gradle project which is just meant as a logical container for subprojects there's no need to apply and plugins to them. This just does unnecessary work and creates tasks that end up getting skipped during execution.

Signed-off-by: Mark Vieira <portugee@gmail.com>
@mark-vieira mark-vieira added the :Delivery/Build Build or test infrastructure label Aug 1, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mark-vieira mark-vieira merged commit 6d7b232 into elastic:master Aug 1, 2019
@mark-vieira mark-vieira deleted the remove-unnecessary-plugins branch August 1, 2019 21:18
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants