Whitelist randomUUID in Painless #45148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdconrad
added
>enhancement
:Core/Infra/Scripting
|
Pinging @elastic/es-core-infra |
|
@rjernst Thanks for the review! Will commit as soon as CI passes. |
jdconrad
added a commit
that referenced
this pull request
Aug 2, 2019
This whitelists randomUUID with the understanding that it's possible for /dev/random to cause blocking on *nix systems. Users that need randomUUID should switch their random generator source to /dev/urandom if this is a concern for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This whitelists randomUUID with the understanding that it's possible for /dev/random to cause blocking on *nix systems. Users that need randomUUID should switch their random generator source to /dev/urandom if this is a concern for them.
Setting /dev/urandom can be done in two ways.
-Djava.security.egd=file:/dev/urandomsecurerandom.source=file:/dev/randomwithsecurerandom.source=file:/dev/urandomAddresses:
#39080