Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geo: Change order of parameter in Geometries to lon, lat #45332

Merged
merged 3 commits into from
Aug 9, 2019

Conversation

imotov
Copy link
Contributor

@imotov imotov commented Aug 8, 2019

Changes the order of parameters in Geometries from lat, lon to lon, lat
and moves all Geometry classes are moved to the
org.elasticsearch.geomtery package.

Closes #45048

Changes the order of parameters in Geometries from lat, lon to lon, lat
and moves all Geometry classes are moved to the
org.elasticsearch.geomtery package.

Closes elastic#45048
@imotov imotov added >enhancement :Analytics/Geo Indexing, search aggregations of geo points and shapes >breaking-java v8.0.0 v7.4.0 labels Aug 8, 2019
@imotov imotov requested review from talevy and nknize August 8, 2019 14:16
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-analytics-geo

@imotov
Copy link
Contributor Author

imotov commented Aug 8, 2019

@elasticmachine run elasticsearch-ci/packaging-sample

Copy link
Contributor

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great.. gives a nice consistency w/ the new shape field. I like that we can use either get{X,Y,Z} or get{Lat, Lon, Alt} in the API.

@imotov imotov merged commit 13a8835 into elastic:master Aug 9, 2019
@imotov
Copy link
Contributor Author

imotov commented Aug 9, 2019

Backport depends on #45363

imotov added a commit to imotov/elasticsearch that referenced this pull request Aug 15, 2019
Changes the order of parameters in Geometries from lat, lon to lon, lat
and moves all Geometry classes are moved to the
org.elasticsearch.geomtery package.

Backport of elastic#45332

Closes elastic#45048
imotov added a commit that referenced this pull request Aug 16, 2019
Changes the order of parameters in Geometries from lat, lon to lon, lat
and moves all Geometry classes are moved to the
org.elasticsearch.geomtery package.

Backport of #45332

Closes #45048
@colings86
Copy link
Contributor

It looks like the backporting is complete here so I have removed the backport pending label while generating 7.4.0 release notes. Please let me know if this is wrong

@imotov
Copy link
Contributor Author

imotov commented Sep 11, 2019

@colings86 yes, I forgot to circle back here and remove the label. Thanks!

@imotov imotov deleted the issue-45048-latlon-to-xy branch May 1, 2020 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/Geo Indexing, search aggregations of geo points and shapes >breaking-java >enhancement v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Geo: Switch Geometry classes from lat, lon, alt to x, y, z
5 participants