Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for authentication based predicate for cluster permission #45431

Commits on Aug 12, 2019

  1. Add support for authentication based predicate for cluster permission

    Currently, cluster permission checks whether a cluster action is
    permitted and optionally in the context of a request. There are
    scenarios where we would want to check whether the cluster action
    is permitted, optionally in the context of a request and current
    authentication. For example, management of API keys is only
    restricted to the API keys owned by the current user. In this case,
    along with the cluster action and API key request, the check
    needs to perform whether the currently authenticated user is indeed
    allowed to operate only on owned API keys.
    With this commit, we are introducing one more context of the current
    authentication that can be considered during permission evaluation.
    
    Relates: elastic#40031
    Yogesh Gaikwad committed Aug 12, 2019
    Copy the full SHA
    80fa13f View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2019

  1. Merge branch 'manage-own-api-key-privilege' into moap-authentication-…

    …based-permission-check
    Yogesh Gaikwad committed Aug 16, 2019
    Copy the full SHA
    60f436b View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2019

  1. address review comments

    The permission checks that are dependent on actions and
    optionally on request and/or on authentication, now
    have a way to specify the predicates. By default
    the implementation will tests all the predicates to be
    successful for the operation to be allowed.
    In case customization is required one has option to
    implement `PermissionCheck`.
    
    - Adds a permission check predicate interface that also
      allows implementers to specify behavior for `implies`.
    Yogesh Gaikwad committed Aug 20, 2019
    Copy the full SHA
    1af1308 View commit details
    Browse the repository at this point in the history
  2. remove unwanted code

    Yogesh Gaikwad committed Aug 20, 2019
    Copy the full SHA
    8896dcd View commit details
    Browse the repository at this point in the history
  3. remove unwanted code change, raise a separate pr for it

    Yogesh Gaikwad committed Aug 20, 2019
    Copy the full SHA
    4976d78 View commit details
    Browse the repository at this point in the history
  4. fix tests

    Yogesh Gaikwad committed Aug 20, 2019
    Copy the full SHA
    54490a7 View commit details
    Browse the repository at this point in the history
  5. precommit error

    Yogesh Gaikwad committed Aug 20, 2019
    Copy the full SHA
    9033996 View commit details
    Browse the repository at this point in the history
  6. oh precommit, ran build on another branch, fixed it

    Yogesh Gaikwad committed Aug 20, 2019
    Copy the full SHA
    541cfad View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2019

  1. Merge branch 'manage-own-api-key-privilege' into moap-authentication-…

    …based-permission-check
    Yogesh Gaikwad committed Aug 21, 2019
    Copy the full SHA
    66fc5b3 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'manage-own-api-key-privilege' into moap-authentication-…

    …based-permission-check
    Yogesh Gaikwad committed Aug 21, 2019
    Copy the full SHA
    de88e11 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2019

  1. address review comments

    Yogesh Gaikwad committed Aug 22, 2019
    Copy the full SHA
    96661a2 View commit details
    Browse the repository at this point in the history
  2. address review comments

    Yogesh Gaikwad committed Aug 22, 2019
    Copy the full SHA
    cf18cf0 View commit details
    Browse the repository at this point in the history