Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inlined user dictionary in the Kuromoji plugin #45489

Merged
merged 3 commits into from
Aug 20, 2019

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Aug 13, 2019

This change adds a new option called user_dictionary_rules to
Kuromoji's tokenizer. It can be used to set additional tokenization rules
to the Japanese tokenizer directly in the settings (instead of using a file).
This commit also adds a check that no rules are duplicated since this is not allowed
in the UserDictionary.

Closes #25343

This change adds a new option called user_dictionary_rules to
Kuromoji's tokenizer. It can be used to set additional tokenization rules
to the Japanese tokenizer directly in the settings (instead of using a file).
This commit also adds a check that no rules are duplicated since this is not allowed
in the UserDictionary.

Closes elastic#25343
@jimczi jimczi added >feature :Search/Analysis How text is split into tokens v8.0.0 v7.4.0 labels Aug 13, 2019
@jimczi jimczi requested a review from cbuescher August 13, 2019 08:32
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@jimczi jimczi requested review from romseygeek and removed request for cbuescher August 16, 2019 08:27
Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jimczi jimczi merged commit d66a307 into elastic:master Aug 20, 2019
@jimczi jimczi deleted the kuromoji_inline_user_dict branch August 20, 2019 13:06
jimczi added a commit that referenced this pull request Aug 21, 2019
This change adds a new option called user_dictionary_rules to
Kuromoji's tokenizer. It can be used to set additional tokenization rules
to the Japanese tokenizer directly in the settings (instead of using a file).
This commit also adds a check that no rules are duplicated since this is not allowed
in the UserDictionary.

Closes #25343
Mpdreamz added a commit to elastic/elasticsearch-net that referenced this pull request Oct 14, 2019
russcam pushed a commit to elastic/elasticsearch-net that referenced this pull request Oct 15, 2019
russcam pushed a commit to elastic/elasticsearch-net that referenced this pull request Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support kuromoji user dictionary set directly in the settings file
4 participants