Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Reformats URI search request #45844
[DOCS] Reformats URI search request #45844
Changes from all commits
607f447
ec07540
f4fb2d0
cfa037c
89fe8f1
5ef5a45
d7c6b7a
edeed21
5baa069
2464829
bfa656e
7ae5fc8
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of "return an overall failure" I'd probably just say "fail the request if only partial results are available." I'd stick with the present tense for the following sentence, too: "Defaults to
true
, which returns partial results in the event oftimeouts or partial failures." I'd probably also use "override" instead of "control"--maybe, "You can override the default behavior for all requests by setting
search.default_allow_partial_results
tofalse
in the cluster settings."There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why I really came here is...do we want to add all of the search-related query parameters to the common parameters? They apply to the search API, delete by query, and update by query.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@debadair @jrodewig I think it's worth to add the search-related query parameters to the common parameters. I'll do it in a separate PR and add both of you as reviewers.