REST cluster state API: Improved consistency #4608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kimchy improved the cluster state API to work like other requests ( |
|
LGTM! |
Instead of specifying what kind of data should be filtered, this commit streamlines the API to actually specify, what kind of data should be displayed. This makes its behaviour similar to the other requests, like NodeIndicesStats. A small feature has been added as well: If you specify an index to select on, not only the metadata, but also the routing tables are filtered by index in order to prevent too big cluster states to be returned. Also the CAT apis have been changed to only return the wanted data in order to keep network traffic as small as needed. Tests for the cluster state API filtering have been added as well. Note: This change breaks backwards compatibility with 0.90! Closes elastic#4065
karmi
added a commit
to elastic/elasticsearch-ruby
that referenced
this pull request
Jan 11, 2014
…` to `/_nodes` The "_cluster" prefix has been removed in Elasticsearch 1.0. The "/_nodes" endpoint is supported since ~ version 0.19, so this doesn't break backwards compatibility. Related: * elastic/elasticsearch#4055 * elastic/elasticsearch#4065 * elastic/elasticsearch#4347 * elastic/elasticsearch#4608
karmi
added a commit
to elastic/elasticsearch-ruby
that referenced
this pull request
Jan 28, 2014
karmi
added a commit
to elastic/elasticsearch-ruby
that referenced
this pull request
Jan 29, 2014
karmi
added a commit
to elastic/elasticsearch-ruby
that referenced
this pull request
Jan 29, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of specifying what kind of data should be filtered, this commit
streamlines the API to actually specify, what kind of data should be displayed.
A small feature has been added as well: If you specify an index to select on, not
only the metadata, but also the routing tables are filtered by index in order
to prevent too big cluster states to be returned.
Also the CAT apis have been changed to only return the wanted data in order to keep
network traffic as small as needed.
Tests for the cluster state API filtering have been added as well.
Note: This change breaks backwards compatibility with 0.90!
Closes #4065