-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate query
field when creating roles
#46275
Commits on Sep 5, 2019
-
Validate
query
field when creating rolesAs of now the validation occurs at runtime when the query is being executed. I think the reason was due to the use of template queries which need runtime information as they need to be evaluated like user information. This commit adds validation for the role query but **not for the template query** as we do not have the runtime information required for evaluating the template query. This also corrects some tests and roles.yml files where the `query` field was not populated correctly. For validation, the query is evaluated (if not a template), parsed to build the `QueryBuilder` and verify if the query type is allowed. Closes elastic#34252
Yogesh Gaikwad committedSep 5, 2019 Configuration menu - View commit details
-
Copy full SHA for 6e1c8b6 - Browse repository at this point
Copy the full SHA 6e1c8b6View commit details
Commits on Sep 10, 2019
-
Yogesh Gaikwad committed
Sep 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 3a5915a - Browse repository at this point
Copy the full SHA 3a5915aView commit details -
Yogesh Gaikwad committed
Sep 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 8e849ff - Browse repository at this point
Copy the full SHA 8e849ffView commit details -
Merge branch 'master' into 34252-fix
Yogesh Gaikwad committedSep 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 5649a69 - Browse repository at this point
Copy the full SHA 5649a69View commit details -
Yogesh Gaikwad committed
Sep 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 8cc234e - Browse repository at this point
Copy the full SHA 8cc234eView commit details -
Yogesh Gaikwad committed
Sep 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 98edc47 - Browse repository at this point
Copy the full SHA 98edc47View commit details -
Yogesh Gaikwad committed
Sep 10, 2019 Configuration menu - View commit details
-
Copy full SHA for 93d0930 - Browse repository at this point
Copy the full SHA 93d0930View commit details
Commits on Sep 12, 2019
-
- add index privileg index to the error message to denote query of which index privilege failed to validate. - add more information to the error message where we know the expected values
Yogesh Gaikwad committedSep 12, 2019 Configuration menu - View commit details
-
Copy full SHA for a1112a5 - Browse repository at this point
Copy the full SHA a1112a5View commit details -
Merge branch 'master' into 34252-fix
Yogesh Gaikwad committedSep 12, 2019 Configuration menu - View commit details
-
Copy full SHA for f4b92af - Browse repository at this point
Copy the full SHA f4b92afView commit details -
- public to package protected method - return immediately for simpler methods - correct the logic in file roles and add tests
Yogesh Gaikwad committedSep 12, 2019 Configuration menu - View commit details
-
Copy full SHA for 145338e - Browse repository at this point
Copy the full SHA 145338eView commit details
Commits on Sep 23, 2019
-
throw error when has privileges request contains index privilege with…
… DLS query
Yogesh Gaikwad committedSep 23, 2019 Configuration menu - View commit details
-
Copy full SHA for 1bcdf18 - Browse repository at this point
Copy the full SHA 1bcdf18View commit details -
Yogesh Gaikwad committed
Sep 23, 2019 Configuration menu - View commit details
-
Copy full SHA for dc5afd4 - Browse repository at this point
Copy the full SHA dc5afd4View commit details -
add better message to help users and is machine readable
Yogesh Gaikwad committedSep 23, 2019 Configuration menu - View commit details
-
Copy full SHA for bc901ce - Browse repository at this point
Copy the full SHA bc901ceView commit details -
Merge branch 'master' into 34252-fix
Yogesh Gaikwad committedSep 23, 2019 Configuration menu - View commit details
-
Copy full SHA for 340f91b - Browse repository at this point
Copy the full SHA 340f91bView commit details
Commits on Sep 25, 2019
-
Merge branch 'master' into 34252-fix
Yogesh Gaikwad committedSep 25, 2019 Configuration menu - View commit details
-
Copy full SHA for cafa9e9 - Browse repository at this point
Copy the full SHA cafa9e9View commit details -
Yogesh Gaikwad committed
Sep 25, 2019 Configuration menu - View commit details
-
Copy full SHA for 0708e44 - Browse repository at this point
Copy the full SHA 0708e44View commit details