terminateAfter added to the RequestConverter #46474
Conversation
|
Pinging @elastic/es-core-features |
|
@hub-cap Cav you review ? |
There was a problem hiding this comment.
Thanks @turackangal for working on this. Can also you modify the RequestConvertersTests#setRandomCountParams() method to randomly set terminate after?
Something like:
if (randomBoolean()) {
countRequest.terminateAfter(randomIntBetween(0, Integer.MAX_VALUE));
expectedParams.put("terminate_after", String.valueOf(countRequest.terminateAfter()));
}
This is used by the testCount() unit test.
Otherwise this PR looks good!
|
Hi @turackangal, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in your Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile? |
| if (randomBoolean()){ | ||
| countRequest.terminateAfter(randomIntBetween(0, Integer.MAX_VALUE)); | ||
| } | ||
| expectedParams.put("terminateAfter", String.valueOf(countRequest.terminateAfter())); |
There was a problem hiding this comment.
We should move this statement inside the body of the if statement and then make sure that terminate after is only serialized if it is not equal to 0 in RequestConverters class line 501. This is an optional parameter and otherwise the HLRC would always send it.
turackangal
force-pushed
the
fix-count-request-fail
branch
from
fea9e22
to
2bd30e6
Compare
martijnvg
force-pushed
the
fix-count-request-fail
branch
from
2bd30e6
to
7061e75
Compare
|
@turackangal Thanks for updating the PR. I think that something went wrong when updating your branch, because the PR included over a hundred other commits. I cleaned it up and made a small change (the actual parameter is |
|
@elasticmachine test this please |
Prior to this commit terminate_after was sent as request body parameter (via SearchSourceBuilder), which is not possible in the count api. Closes elastic#46446
martijnvg
force-pushed
the
fix-count-request-fail
branch
from
7061e75
to
323a3bf
Compare
|
@elasticmachine test this please |
Prior to this commit min_score was sent as request body parameter (via SearchSourceBuilder), which is not possible in the count api. Similar to elastic#46474
) Prior to this commit min_score was sent as request body parameter (via SearchSourceBuilder), which is not possible in the count api. Similar to #46474
) Prior to this commit min_score was sent as request body parameter (via SearchSourceBuilder), which is not possible in the count api. Similar to #46474
) Prior to this commit min_score was sent as request body parameter (via SearchSourceBuilder), which is not possible in the count api. Similar to #46474
Fix #46446