Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SnapshotStatusApisIT #46563

Merged

Conversation

original-brownbear
Copy link
Member

Obviously we have to run the status request again to busy wait for
the STARTED state, just busy waiting on an existing response
won't do anything.

Closes #45917

Obviously we have to run the status request again to busy wait for
the `STARTED` state, just busy waiting on an existing response
won't do anything.

Closes elastic#45917
@original-brownbear original-brownbear added >test Issues or PRs that are addressing/adding tests :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 v7.5.0 labels Sep 10, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

Copy link
Member

@tlrx tlrx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤦‍♂️

@original-brownbear
Copy link
Member Author

Thanks Tanguy :) 🤦‍♂️ indeed :D

@original-brownbear original-brownbear merged commit 078a371 into elastic:master Sep 11, 2019
@original-brownbear original-brownbear deleted the fix-sn-status-api-IT branch September 11, 2019 07:29
original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Sep 11, 2019
Obviously we have to run the status request again to busy wait for
the `STARTED` state, just busy waiting on an existing response
won't do anything.

Closes elastic#45917
original-brownbear added a commit that referenced this pull request Sep 11, 2019
Obviously we have to run the status request again to busy wait for
the `STARTED` state, just busy waiting on an existing response
won't do anything.

Closes #45917
turackangal pushed a commit to turackangal/elasticsearch that referenced this pull request Sep 14, 2019
Obviously we have to run the status request again to busy wait for
the `STARTED` state, just busy waiting on an existing response
won't do anything.

Closes elastic#45917
@ywelsch
Copy link
Contributor

ywelsch commented Sep 25, 2019

Can you backport this to all active branches? There are more failures of this on CI, e.g. on 7.4 branch, see https://gradle-enterprise.elastic.co/s/u3dbmvyrkg3ju

original-brownbear added a commit to original-brownbear/elasticsearch that referenced this pull request Sep 25, 2019
Obviously we have to run the status request again to busy wait for
the `STARTED` state, just busy waiting on an existing response
won't do anything.

Closes elastic#45917
@original-brownbear
Copy link
Member Author

Sure, incoming in #47075 (7.4 should be the only other active branch that contains this test)

original-brownbear added a commit that referenced this pull request Sep 25, 2019
Obviously we have to run the status request again to busy wait for
the `STARTED` state, just busy waiting on an existing response
won't do anything.

Closes #45917
@original-brownbear original-brownbear restored the fix-sn-status-api-IT branch August 6, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >test Issues or PRs that are addressing/adding tests v7.5.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] test failure SnapshotStatusApisIT.testStatusAPICallInProgressSnapshot
5 participants