Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: improve ResultSet behavior when no rows are available #46753

Merged
merged 2 commits into from
Sep 17, 2019
Merged

SQL: improve ResultSet behavior when no rows are available #46753

merged 2 commits into from
Sep 17, 2019

Conversation

costin
Copy link
Member

@costin costin commented Sep 16, 2019

Improve the defensive behavior of ResultSet when dealing with incorrect
API usage. In particular handle the case of dealing with no row
available (either because the cursor is before the first entry or after
the last).

Fix #46750

@costin
SQL: improve ResultSet behavior when no rows are available
2aa2e48 
Improve the defensive behavior of ResultSet when dealing with incorrect
API usage. In particular handle the case of dealing with no row
available (either because the cursor is before the first entry or after
the last).

Fix elastic#46750
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@costin
Copy link
Member Author

costin commented Sep 16, 2019

@elasticmachine run elasticsearch-ci/2

astefan
astefan approved these changes Sep 17, 2019
View reviewed changes
Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin costin merged commit 58fa38e into elastic:master Sep 17, 2019
@costin costin deleted the fix/46750 branch September 17, 2019 07:41
@colings86 colings86 added v7.4.0 and removed v7.4.1 labels Sep 17, 2019
costin added a commit that referenced this pull request Sep 17, 2019
@costin
SQL: improve ResultSet behavior when no rows are available (#46753)
e9ea171 
Improve the defensive behavior of ResultSet when dealing with incorrect
API usage. In particular handle the case of dealing with no row
available (either because the cursor is before the first entry or after
the last).

Fix #46750

(cherry picked from commit 58fa38e)
costin added a commit that referenced this pull request Sep 17, 2019
@costin
SQL: improve ResultSet behavior when no rows are available (#46753)
fdfdf99 
Improve the defensive behavior of ResultSet when dealing with incorrect
API usage. In particular handle the case of dealing with no row
available (either because the cursor is before the first entry or after
the last).

Fix #46750

(cherry picked from commit 58fa38e)
costin added a commit that referenced this pull request Sep 17, 2019
@costin
SQL: improve ResultSet behavior when no rows are available (#46753)
90f4c23 
Improve the defensive behavior of ResultSet when dealing with incorrect
API usage. In particular handle the case of dealing with no row
available (either because the cursor is before the first entry or after
the last).

Fix #46750

(cherry picked from commit 58fa38e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astefan astefan astefan approved these changes

@matriv matriv Awaiting requested review from matriv

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >bug v7.3.3 v7.4.0 v7.5.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL: incorrect use of ResultSet does not throw SQLException
5 participants
@costin @elasticmachine @astefan @colings86 @jakelandis