Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function submitDeleteByQueryTask in class RestHighLevelClient #46833

Merged
merged 8 commits into from
Sep 24, 2019
Merged

add function submitDeleteByQueryTask in class RestHighLevelClient #46833

merged 8 commits into from
Sep 24, 2019

Conversation

qianyuxiang01
Copy link
Contributor

add function submitDeleteByQueryTask in class RestHighLevelClient and an unit test for submitDeleteByQueryTask

qianyuxiang and others added 4 commits September 17, 2019 20:18
The HLRC has a method for reindex, that allows to trigger an async reindex by running RestHighLevelClient.submitReindexTask and RestHighLevelClient.reindex. The delete by query however only has an RestHighLevelClient.deleteByQuery method (and its async counterpart), but no RestHighLevelClient.submitDeleteByQueryTask. So add RestHighLevelClient.submitDeleteByQueryTask
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features

@martijnvg
Copy link
Member

@elasticmachine test this please

@martijnvg
Copy link
Member

@qianyuxiang01 Thanks for working on this! This looks good to me. I will merge this when the build passes.

@martijnvg
Copy link
Member

@qianyuxiang01 The check style task failed in the build:

13:08:15 > Task :client:rest-high-level:checkstyleMain FAILED
13:08:15 [ant:checkstyle] [ERROR] /run/shm/elastic+elasticsearch+pull-request-1/client/rest-high-level/src/main/java/org/elasticsearch/client/RequestConverters.java:576: Line is longer than 140 characters (found 145). [LineLength]
13:08:15 [ant:checkstyle] [ERROR] /run/shm/elastic+elasticsearch+pull-request-1/client/rest-high-level/src/main/java/org/elasticsearch/client/RestHighLevelClient.java:601: Line is longer than 140 characters (found 151). [LineLength]

Can you make sure that these lines are no longer than 140 characters? After you make the change you can run locally: ./gradlew -p client/rest-high-level/ precommit to verify that checkstyle task succeeds.

@martijnvg
Copy link
Member

@elasticmachine test this please

@martijnvg
Copy link
Member

@qianyuxiang01 The RequestConvertersTests.testDeleteByQuery(...) fails. I think it needs to be modified to take into account that wait_for_completion param is now also provided. Could you make this change in this test?

@qianyuxiang01
Copy link
Contributor Author

qianyuxiang01 commented Sep 23, 2019 via email

@martijnvg
Copy link
Member

@elasticmachine test this please

@martijnvg
Copy link
Member

@qianyuxiang01 Thanks for fixing the test. I've started a new build.

@martijnvg martijnvg merged commit 2733e91 into elastic:master Sep 24, 2019
martijnvg pushed a commit that referenced this pull request Sep 24, 2019
The HLRC has a method for reindex, that allows to trigger an async reindex by running RestHighLevelClient.submitReindexTask and RestHighLevelClient.reindex. The delete by query however only has an RestHighLevelClient.deleteByQuery method (and its async counterpart), but no RestHighLevelClient.submitDeleteByQueryTask. So add RestHighLevelClient.submitDeleteByQueryTask

Closes #46395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants