-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add function submitDeleteByQueryTask in class RestHighLevelClient #46833
Conversation
The HLRC has a method for reindex, that allows to trigger an async reindex by running RestHighLevelClient.submitReindexTask and RestHighLevelClient.reindex. The delete by query however only has an RestHighLevelClient.deleteByQuery method (and its async counterpart), but no RestHighLevelClient.submitDeleteByQueryTask. So add RestHighLevelClient.submitDeleteByQueryTask
Pinging @elastic/es-core-features |
@elasticmachine test this please |
@qianyuxiang01 Thanks for working on this! This looks good to me. I will merge this when the build passes. |
@qianyuxiang01 The check style task failed in the build:
Can you make sure that these lines are no longer than 140 characters? After you make the change you can run locally: |
@elasticmachine test this please |
@qianyuxiang01 The |
ok. I will fix this today
| |
钱宇翔
邮箱:qianyuxiang01@126.com
|
签名由 网易邮箱大师 定制
On 09/24/2019 01:57, Martijn van Groningen wrote:
@qianyuxiang01 The RequestConvertersTests.testDeleteByQuery(...) fails. I think it needs to be modified to take into account that wait_for_completion param is now also provided. Could you make this change in this test?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
…nal param wait_for_completion, so add it (#46395)
@elasticmachine test this please |
@qianyuxiang01 Thanks for fixing the test. I've started a new build. |
The HLRC has a method for reindex, that allows to trigger an async reindex by running RestHighLevelClient.submitReindexTask and RestHighLevelClient.reindex. The delete by query however only has an RestHighLevelClient.deleteByQuery method (and its async counterpart), but no RestHighLevelClient.submitDeleteByQueryTask. So add RestHighLevelClient.submitDeleteByQueryTask Closes #46395
add function submitDeleteByQueryTask in class RestHighLevelClient and an unit test for submitDeleteByQueryTask