Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the number of vector dims to 2048 #46895

Merged

Conversation

mayya-sharipova
Copy link
Contributor

No description provided.

@mayya-sharipova mayya-sharipova added the :Search/Search Search-related issues that do not fall into other categories label Sep 19, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search

@mayya-sharipova
Copy link
Contributor Author

As there are some neural networks that produce vectors with dims > 1024 (see a discussion here, we need to increase the max dims to 2048.

@mayya-sharipova
Copy link
Contributor Author

For 7.5 backport a note with increased number of dims will be added to migrate_7_5.asciidoc.

@mayya-sharipova
Copy link
Contributor Author

@jtibshirani This PR is ready for another review.

@mayya-sharipova
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/1

@mayya-sharipova
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs-check

@mayya-sharipova
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/oss-distro-docs

Copy link
Contributor

@jtibshirani jtibshirani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@jtibshirani
Copy link
Contributor

jtibshirani commented Nov 19, 2019

For future context, we made the decision to raise the limit because we've encountered a couple well-known models that produce vectors with > 1024 dimensions.

We're not planning to increase the limit further unless we hear from a few users about common models/ use cases that require more dimensions.

@mayya-sharipova mayya-sharipova merged commit 19b6b36 into elastic:master Nov 20, 2019
@mayya-sharipova mayya-sharipova deleted the vector-increse-max-dims branch November 20, 2019 12:43
@jtibshirani jtibshirani added :Search Relevance/Vectors Vector search and removed :Search/Search Search-related issues that do not fall into other categories labels Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants