-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added stopwords: _none_ to the docs #329 #4698
Conversation
Hi @mrkamel Many thanks for this PR. Reading through it made me realise that we have some inconsistent changes coming up. In 1.0 we have set the default stopwords list on new indices for the I've just opened #4699 to get the Also, please could you sign the CLA http://www.elasticsearch.org/contributor-agreement so that we can accept these changes. many thanks |
a) The docs of master state
b) I agree, we should wait for the removal of inconsistencies
was already listed in the page's sample config. Thus, i assume stopwords should not be listed on this page at all and we should provide an extra page for them to have less duplication in the docs and then reference it where neccessary. Where do you want it to live? |
Great, #4699 seems to be fixed. Do you agree to my proposal in d) ? |
Heya Re:
No need to close this PR, you can just update it and push again. thanks for helping @mrkamel |
also please include the ta |
Before, may i finally ask why ES actually uses such kind of special keyword Sorry for being pedantic, but i don't easily find an obvious hint within the sources. |
Good question, and I don't know either :) Looks like an empty list isn't being considered currently. I've opened #4709 to get support added (but this may take a little while as we're getting ready for the next release now). |
Merged! Many thanks for the PR @mrkamel |
I'm missing
stopwords: _none_
in the docs, as well as astopwords: ...
section within the pattern analyzer docs.