Warn on slow metadata persistence #47005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Today if metadata persistence is excessively slow on a master-ineligible node then the `ClusterApplierService` emits a warning indicating that the `GatewayMetaState` applier was slow, but gives no further details. If it is excessively slow on a master-eligible node then we do not see any warning at all, although we might see other consequences such as a lagging node or a master failure. With this commit we emit a warning if metadata persistence takes longer than a configurable threshold, which defaults to `10s`. We also emit statistics that record how much index metadata was persisted and how much was skipped since this can help distinguish cases where IO was slow from cases where there are simply too many indices involved.
DaveCTurner
added
>enhancement
:Distributed/Cluster Coordination
|
Pinging @elastic/es-distributed |
|
Failure looks unrelated, I opened #47012. @elasticmachine please run elasticsearch-ci/1. |
ywelsch
approved these changes
Sep 25, 2019
| @@ -320,6 +358,22 @@ void rollback() { | |||
| rollbackCleanupActions.forEach(Runnable::run); | |||
| finished = true; | |||
| } | |||
|
|
|||
| void incrementIndicesWritten() { | |||
There was a problem hiding this comment.
perhaps we can just make the fields package-visible and operate directly on them, removing getter and setters here, given that their are only used within IncrementalClusterStateWriter. Reduces the amount of clutter and avoids the extra test provisions for the interaction mocking.
There was a problem hiding this comment.
Asserting on the interactions with the increment* methods is deliberate; it would add a good deal more noise to check that they're being called in a different way.
DaveCTurner
deleted the
2019-09-24-warn-on-slow-metadata-persistence
branch
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Sep 25, 2019
Today if metadata persistence is excessively slow on a master-ineligible node then the `ClusterApplierService` emits a warning indicating that the `GatewayMetaState` applier was slow, but gives no further details. If it is excessively slow on a master-eligible node then we do not see any warning at all, although we might see other consequences such as a lagging node or a master failure. With this commit we emit a warning if metadata persistence takes longer than a configurable threshold, which defaults to `10s`. We also emit statistics that record how much index metadata was persisted and how much was skipped since this can help distinguish cases where IO was slow from cases where there are simply too many indices involved.
DaveCTurner
added a commit
that referenced
this pull request
Sep 26, 2019
Today if metadata persistence is excessively slow on a master-ineligible node then the `ClusterApplierService` emits a warning indicating that the `GatewayMetaState` applier was slow, but gives no further details. If it is excessively slow on a master-eligible node then we do not see any warning at all, although we might see other consequences such as a lagging node or a master failure. With this commit we emit a warning if metadata persistence takes longer than a configurable threshold, which defaults to `10s`. We also emit statistics that record how much index metadata was persisted and how much was skipped since this can help distinguish cases where IO was slow from cases where there are simply too many indices involved. Backport of #47005.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today if metadata persistence is excessively slow on a master-ineligible node
then the
ClusterApplierServiceemits a warning indicating that theGatewayMetaStateapplier was slow, but gives no further details. If it isexcessively slow on a master-eligible node then we do not see any warning at
all, although we might see other consequences such as a lagging node or a
master failure.
With this commit we emit a warning if metadata persistence takes longer than a
configurable threshold, which defaults to
10s. We also emit statistics thatrecord how much index metadata was persisted and how much was skipped since
this can help distinguish cases where IO was slow from cases where there are
simply too many indices involved.