Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AD realm additional metadata #47179

Conversation

albertzaharovits
Copy link
Contributor

Due to a regression bug the metadata Active Directory realm setting is ignored (it works correctly for the LDAP realm type). This commit redresses it.

Closes #45848

@albertzaharovits albertzaharovits added >bug :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v8.0.0 v7.5.0 v7.4.1 labels Sep 26, 2019
@albertzaharovits albertzaharovits self-assigned this Sep 26, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-security

Copy link
Contributor

@bizybot bizybot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.
There are some compilation errors but the change look good to me.

Copy link
Member

@jkakavas jkakavas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green CI

@albertzaharovits albertzaharovits merged commit dea96fb into elastic:master Oct 1, 2019
@albertzaharovits albertzaharovits deleted the fix-ad-realm-additional-metadata branch October 1, 2019 11:29
albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Oct 1, 2019
Due to a regression bug the metadata Active Directory realm
setting is ignored (it works correctly for the LDAP realm type).
This commit redresses it.

Closes elastic#45848
albertzaharovits added a commit that referenced this pull request Oct 1, 2019
Due to a regression bug the metadata Active Directory realm
setting is ignored (it works correctly for the LDAP realm type).
This commit redresses it.

Closes #45848
albertzaharovits added a commit that referenced this pull request Oct 1, 2019
Due to a regression bug the metadata Active Directory realm
setting is ignored (it works correctly for the LDAP realm type).
This commit redresses it.

Closes #45848
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Oct 2, 2019
The changes introduced in elastic#47179 made it so that we could try to
build an SSLContext with verification mode set to None, which is
not allowed in FIPS 140 JVMs. This commit address that
jkakavas added a commit that referenced this pull request Oct 3, 2019
The changes introduced in #47179 made it so that we could try to
build an SSLContext with verification mode set to None, which is
not allowed in FIPS 140 JVMs. This commit address that
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Oct 3, 2019
The changes introduced in elastic#47179 made it so that we could try to
build an SSLContext with verification mode set to None, which is
not allowed in FIPS 140 JVMs. This commit address that
jkakavas added a commit that referenced this pull request Oct 3, 2019
The changes introduced in #47179 made it so that we could try to
build an SSLContext with verification mode set to None, which is
not allowed in FIPS 140 JVMs. This commit address that
jkakavas added a commit to jkakavas/elasticsearch that referenced this pull request Oct 12, 2019
The changes introduced in elastic#47179 made it so that we could try to
build an SSLContext with verification mode set to None, which is
not allowed in FIPS 140 JVMs. This commit address that
jkakavas added a commit that referenced this pull request Oct 12, 2019
The changes introduced in #47179 made it so that we could try to
build an SSLContext with verification mode set to None, which is
not allowed in FIPS 140 JVMs. This commit address that
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) v7.4.1 v7.5.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metadata setting is not available for Active Directory realms
5 participants