Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SQL: use calendar interval of 1y instead of fixed interval for grouping by YEAR and HISTOGRAMs #47558

Merged
merged 4 commits into from
Oct 9, 2019
Merged

SQL: use calendar interval of 1y instead of fixed interval for grouping by YEAR and HISTOGRAMs #47558

merged 4 commits into from
Oct 9, 2019

Conversation

astefan
Copy link
Contributor

@astefan astefan commented Oct 4, 2019

Because Elasticsearch forces users to use a fixed interval for all nX periods of time (3 days, 4 years, 5 months etc), to have a consistent behavior throughout SQL, the fixed_interval approach was chosen. But this resulted in having an unintuitive behavior for intervals of one year.
This PR changes grouping by YEAR() and HISTOGRAMs with INTERVAL '1' YEAR to use a date_histogram with calendar_interval of 1y.

Fixes #40162.

@astefan astefan requested review from costin and matriv October 4, 2019 09:20
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/SQL)

matriv
matriv approved these changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

costin
costin approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@costin costin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@costin
Copy link
Member

costin commented Oct 7, 2019

Make sure to indicate the versions selected for backporting. Considering it's a behavior change, I'm on the fence on whether we should do any backporting.

@astefan
Copy link
Contributor Author

astefan commented Oct 9, 2019

@elasticmachine run elasticsearch-ci/packaging-sample

@astefan astefan merged commit 55f5463 into elastic:master Oct 9, 2019
astefan added a commit that referenced this pull request Oct 9, 2019
@astefan
SQL: use calendar interval of 1y instead of fixed interval for groupi…
75a7daa 
…ng by YEAR and HISTOGRAMs (#47558)

(cherry picked from commit 55f5463)
@astefan astefan deleted the 40162_fix branch October 9, 2019 08:52
@astefan astefan mentioned this pull request Oct 9, 2019
Closed
@elasticforme elasticforme mentioned this pull request Feb 18, 2020
Closed
@matriv matriv mentioned this pull request Jun 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@costin costin costin approved these changes

@matriv matriv matriv approved these changes

Assignees
No one assigned
Labels
:Analytics/SQL SQL querying >enhancement v7.5.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SQL: inconsistent results for YEAR method
5 participants
@astefan @elasticmachine @costin @matriv @jakelandis