Validate monitoring username at parse time #47821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-features (:Core/Features/Monitoring) |
danhermann
changed the title
jakelandis
reviewed
Oct 14, 2019
| new Setting.Validator<String>() { | ||
| @Override | ||
| public void validate(String password) { | ||
|
|
There was a problem hiding this comment.
nit: comment to why empty
|
@elastic/es-core-infra, this work covers both monitoring and settings if you want to review it. |
|
@elasticmachine, run elasticsearch-ci/2 |
|
@elasticmachine, run elasticsearch-ci/bwc |
rjernst
approved these changes
Oct 28, 2019
| if (Strings.isNullOrEmpty(username) == false) { | ||
| if (Strings.isNullOrEmpty(password)) { | ||
| throw new SettingsException( | ||
| "[" + AUTH_USERNAME_SETTING.getConcreteSettingForNamespace(namespace).getKey() + "] without [" + |
There was a problem hiding this comment.
Could we have a more explicit message? This is something a user sees that must be acted upon. Perhaps something for the form "XXX is set but YYY is missing"
|
@elasticmachine update branch |
|
@elasticmachine run elasticsearch-ci/2 |
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Oct 31, 2019
This was referenced Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides parse-time validation for
AUTH_USERNAME_SETTINGas described in #47711.